Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parents field to timeline events #2566

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Conversation

lyoung-confluent
Copy link
Contributor

The committed events from the timeline API can have a parents field containing the parent commits:

    "parents": [
      {
        "sha": "29480ba555d614487fddba278d32d19102e86527",
        "url": "https://api.github.com/repos/google/go-github/git/commits/29480ba555d614487fddba278d32d19102e86527",
        "html_url": "https://github.com/google/go-github/commit/29480ba555d614487fddba278d32d19102e86527"
      }
    ],

This is also documented on the issue event payload: https://docs.github.com/en/developers/webhooks-and-events/events/issue-event-types#event-object-properties-7

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #2566 (35caea3) into master (ddfa307) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2566   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files         125      125           
  Lines       10875    10875           
=======================================
  Hits        10656    10656           
  Misses        150      150           
  Partials       69       69           
Impacted Files Coverage Δ
github/issues_timeline.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lyoung-confluent !
LGTM.
Merging.

@gmlewis gmlewis merged commit 155b546 into google:master Nov 15, 2022
@lyoung-confluent lyoung-confluent deleted the patch-1 branch November 15, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants