Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change create fork options from url param to body param #2490

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Change create fork options from url param to body param #2490

merged 3 commits into from
Dec 9, 2022

Conversation

valbeat
Copy link
Contributor

@valbeat valbeat commented Oct 11, 2022

resolves #2489

@codecov
Copy link

codecov bot commented Oct 11, 2022 •
edited
Loading

Codecov Report

Merging #2490 (ba1f7ad) into master (3dcfcf6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2490      +/-   ##
==========================================
- Coverage   97.97%   97.97%   -0.01%     
==========================================
  Files         123      123              
  Lines       10813    10810       -3     
==========================================
- Hits        10594    10591       -3     
  Misses        150      150              
  Partials       69       69
Impacted Files Coverage Δ
github/repos_forks.go 91.66% <100.00%> (-0.65%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gmlewis
gmlewis approved these changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @valbeat !
LGTM.

Awaiting second LGTM from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 3, 2022
@TruRelax
Copy link

TruRelax commented Dec 1, 2022

It's been blocked for weeks 😢

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 1, 2022

It's been blocked for weeks 😢

This repo depends on volunteers to contribute both code and code reviews to move it forward. If you are a contributor to this repo, please feel free to perform a code review and LGTM+Approval if you agree with this change.

@valbeat valbeat mentioned this pull request Dec 2, 2022
Closed
raynigon
raynigon approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@raynigon raynigon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis Sorry for the late review, feel free to mention me if a review is needed.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Dec 9, 2022
@gmlewis
Copy link
Collaborator

gmlewis commented Dec 9, 2022

LGTM

@gmlewis Sorry for the late review, feel free to mention me if a review is needed.

Thank you, @raynigon , and no worries!
Merging.

@gmlewis gmlewis merged commit 3e3f03c into google:master Dec 9, 2022
@valbeat
Copy link
Contributor Author

valbeat commented Dec 13, 2022

Thanks for review!

@valbeat valbeat deleted the fix/change-create-fork-options branch December 13, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raynigon raynigon raynigon approved these changes

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RepositoryCreateForkOptions is should be body parameters
4 participants
@valbeat @TruRelax @gmlewis @raynigon