Fix RequireCodeOwnerReviews and RequiredApprovingReviewCount fields with omitempty #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlewis
requested changes
Feb 12, 2022
There was a problem hiding this comment.
Thank you, @leopoldwang !
Please run go generate ./... and push (not force-push) the changes to this PR.
See CONTRIBUTING.md for more details.
gmlewis
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2289 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 115 115
Lines 10360 10360
=======================================
Hits 10136 10136
Misses 156 156
Partials 68 68
Continue to review full report at Codecov.
|
gmlewis
reviewed
Feb 12, 2022
gmlewis
reviewed
Feb 13, 2022
gmlewis
approved these changes
Feb 13, 2022
There was a problem hiding this comment.
Thank you, @leopoldwang !
One tiny nit, but otherwise LGTM.
Awaiting second LGTM/Approval from any other contributor to this repo.
gmlewis
added
the
Breaking API Change
Added missing period. Co-authored-by: Glenn Lewis <[email protected]>
gmlewis
approved these changes
Feb 14, 2022
raynigon
approved these changes
Feb 14, 2022
|
LGTM. |
|
Thank you, @raynigon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2286.