Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Preview Review Requests API #516

Closed
gmlewis opened this issue Jan 12, 2017 · 6 comments · Fixed by #557
Closed

Add support for Preview Review Requests API #516

gmlewis opened this issue Jan 12, 2017 · 6 comments · Fixed by #557
Assignees
@varadarajana

Comments

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 12, 2017

Announcement:
https://developer.github.com/changes/2016-12-16-review-requests-api/
@dmitshur
Copy link
Member

dmitshur commented Jan 12, 2017 •
edited
Loading

Imagine the struct for "create a review request" endpoint options being named... PullRequestReviewRequestRequest. 😆

(I'm kidding, hopefully it won't come to that.)

@gmlewis
Copy link
Collaborator Author

gmlewis commented Jan 12, 2017

Looks like Java in Go! 😄

@varadarajana
Copy link
Contributor

@gmlewis if this is not assigned already, please assign it to me. I am almost done with #530

@dmitshur dmitshur mentioned this issue Feb 21, 2017
Merged
@dmitshur
Copy link
Member

It looks like #557 is related.

@varadarajana, @sevki, you should coordinate to avoid duplicate work.

@varadarajana
Copy link
Contributor

varadarajana commented Feb 26, 2017 •
edited
Loading

@shurcooL this issue can be closed, as it is duplicate of #557

@dmitshur
Copy link
Member

It's not a duplicate issue because #557 is a PR, not an issue. The issue tracks the completion of the relevant functionality. It shouldn't be closed until this functionality is implemented.

#557 is a PR that will resolve this issue.

dmitshur pushed a commit that referenced this issue Mar 8, 2017
@sevki @dmitshur
Add PullRequestsService.{Request,List,Remove}Reviewers. (#557)
cfbfe91 
Add support for an addition to the Pull Request Reviews API,
the ability to manage Review Requests.

GitHub announcement: https://developer.github.com/changes/2016-12-16-review-requests-api/
GitHub API docs: https://developer.github.com/v3/pulls/review_requests/

Resolves #516.
bubg-dev pushed a commit to bubg-dev/go-github that referenced this issue Jun 16, 2017
@sevki @dmitshur
Add PullRequestsService.{Request,List,Remove}Reviewers. (google#557)
3489bba 
Add support for an addition to the Pull Request Reviews API,
the ability to manage Review Requests.

GitHub announcement: https://developer.github.com/changes/2016-12-16-review-requests-api/
GitHub API docs: https://developer.github.com/v3/pulls/review_requests/

Resolves google#516.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varadarajana varadarajana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add requestreviewers sevki/go-github
3 participants
@dmitshur @gmlewis @varadarajana