Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub Actions API #1399

Closed
joshuabezaleel opened this issue Jan 28, 2020 · 22 comments
Closed

Support GitHub Actions API #1399

joshuabezaleel opened this issue Jan 28, 2020 · 22 comments

Comments

@joshuabezaleel
Copy link
Contributor

joshuabezaleel commented Jan 28, 2020

Announcement: https://developer.github.com/v3/actions/

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 28, 2020

Usually there is a blog announcement, and apparently there wasn't for this. Thanks, @joshuabezaleel.

This would be a great PR for any new contributor to this repo or any Go developer.
All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started.

Thank you!

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 28, 2020

actions_secrets.go - assigned to @martinssipenko.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 29, 2020

In order to fully close this issue, we need PRs that will address all the following sections of the announcement:

Since this is a lot of work, let's open this up to multiple developers... please volunteer for one section in the list above, and piggy-back upon the excellent work that @martinssipenko has started in #1402.

Thank you!

@joshuabezaleel
Copy link
Contributor Author

Haven't got a chance to look at it but I want to take a shot. Perhaps the actions_workflows one.

@sprsld
Copy link
Contributor

sprsld commented Jan 29, 2020

May I contribute to the actions_artifacts section?

@joshuabezaleel
Copy link
Contributor Author

joshuabezaleel commented Feb 5, 2020

Since my incoming PR will be dependent to @martinssipenko 's PR that contains ActionsService on actions.go, should I wait for that particular PR to be merged or I can raise a PR with ActionsService written in my code as if it's already merged?

cc: @gmlewis

@martinssipenko
Copy link
Contributor

@joshuabezaleel you can branch off of my branch.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 6, 2020

Hey volunteers, I am super-pleased with the way this Issue is coming together... starting off with the excellent groundwork from @martinssipenko followed by another great PR from @joshuabezaleel!

Let's keep up this excellent progress going by having more people volunteer to complete the unchecked and unassigned items above.

Please remember to check out our CONTRIBUTING.md guide to get started... and thank you in advance for your contributions!

@nightlark
Copy link
Contributor

Interested in getting the actions_runners working.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 7, 2020

Interested in getting the actions_runners working.

@nightlark - does that mean you are volunteering to implement action_runners.go or you are just interested that someone gets this working?
I would hate to assign this issue to you if it is just the latter. 😄

If it is the former, thank you very much, and I will put your name as its owner.

@joshuabezaleel
Copy link
Contributor Author

I would love to work more on this if it's permissible and no one is taking it. But if we should distribute the contribution, that would be lovely to do so 🙂 cc: @gmlewis

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 8, 2020

Hi @joshuabezaleel - that's fantastic... thank you!

I think we give people ample opportunity to sign up for working on this repo, so feel free to volunteer for more endpoints (as we await LGTMs). (I think we should probably give @nightlark another day to respond to my question... so feel free to pick a different one while we are waiting for a response. 😄)

@nightlark
Copy link
Contributor

@gmlewis I’ll take on implementing support for the runners api.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 9, 2020

@gmlewis I’ll take on implementing support for the runners api.

Thank you, @nightlark! I've assigned actions_runners.go to you above.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 12, 2020

Hi awesome volunteers, we still have one task above that needs an implementation.

Now that pioneers like @martinssipenko, @joshuabezaleel, and @Atorr have forged ahead with their portions, there are excellent examples to base the remaining work upon.

Please remember to check out our CONTRIBUTING.md guide to get started... and thank you in advance for your contributions!

@ayzu
Copy link
Contributor

ayzu commented Feb 22, 2020

Hi guys!

I would like to work on the last issue: actions_workflow_runs.go

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 22, 2020

Thank you, @ayzu! It is yours.

gmlewis pushed a commit that referenced this issue Feb 27, 2020
gmlewis pushed a commit that referenced this issue Feb 27, 2020
@bramwelt
Copy link

Testing out the CreateOrUpdateSecret function, I seem to always be getting a 204 No Content response back even when creating new secrets (which should return 201 Created). I'm curious if anyone else has seen this or if perhaps I'm getting a cached response from my own code?

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 27, 2020

@martinssipenko - can you please comment on #1399 (comment) ?

@martinssipenko
Copy link
Contributor

martinssipenko commented Feb 28, 2020

@gmlewis @bramwelt I tested the API manually and despite what documentations suggests, it indeed returns 204 No Content on both create and update.

I've reached out to GitHub support and updated the conversion with them in #1402, #1402 (comment)

I'll post their response there and will mention you so you both are up to date.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 28, 2020

Thank you, @martinssipenko ! Your efforts are greatly appreciated!

@joshuabezaleel
Copy link
Contributor Author

Agreed, thank you lots @martinssipenko !! Truly appreciate it 🙂

@gmlewis gmlewis closed this as completed in 5a0c02d Mar 3, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this issue Oct 2, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this issue Oct 2, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this issue Oct 2, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this issue Oct 2, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this issue Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants