-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request > New branch protection features support #1345
Comments
@gmlewis is this a feature that we would like to add, if so, could i try to work on this as a newb? 😃 |
Hi @anorek - I haven't had a chance to verify this one yet, so that would be the first step. So yes, it is yours. Thank you! 😁 |
I'm sorry, @anorek - it looks like @pcantea already submitted a PR for this. @pcantea - in the future, could you please note in the issue (here) that you would like to work on it before sending a PR? It was already assigned to @anorek and if we communicate clearly, it can hopefully avoid developer frustration and prevent duplication of effort. So @anorek - I hope you have not wasted too much time on this issue... but if you are OK with moving forward with @pcantea's PR in #1354, then that's how we'll proceed. I'll assume that so that we can hopefully keep moving forward and start reviewing the PR. |
Of course Glenn! No worries at all!
Have a lovely Christmas and please enjoy the holidays!
…On Tue, Dec 24, 2019, 03:14 Glenn Lewis ***@***.***> wrote:
I'm sorry, @anorek <https://github.com/anorek> - it looks like @pcantea
<https://github.com/pcantea> already submitted a PR for this.
@pcantea <https://github.com/pcantea> - in the future, could you please
note in the issue (here) that you would like to work on it before sending a
PR? It was already assigned to @anorek <https://github.com/anorek> and if
we communicate clearly, it can hopefully avoid developer frustration and
prevent duplication of effort.
So @anorek <https://github.com/anorek> - I hope you have not wasted too
much time on this issue... but if you are OK with moving forward with
@pcantea <https://github.com/pcantea>'s PR in #1354
<#1354>, then that's how we'll
proceed. I'll assume that so that we can hopefully keep moving forward and
start reviewing the PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1345?email_source=notifications&email_token=AMCMMA3IHJ4BLX3LETBYYSLQ2FWAVA5CNFSM4JW6HI6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHSJH5A#issuecomment-568628212>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMCMMAZDKRUHJNPFUAPCMADQ2FWAVANCNFSM4JW6HI6A>
.
|
Thank you for your understanding, @anorek! Merry Christmas to you too! |
@gmlewis hey glen, just want to say that you are a wonderful maintainer! while I am grateful that you are such a hard worker and continue to create a good open source environment, I can only wish that you would be able to take the day off and enjoy the holiday and best of the health for you! ❤️ |
Thank you, @anorek, for the kind words! Best wishes to you too! |
Hi,
Please add support for the new branch protection features:
required_linear_history
allow_force_pushes
allow_deletions
See: https://developer.github.com/v3/repos/branches/#update-branch-protection
Thanks!
The text was updated successfully, but these errors were encountered: