Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request > New branch protection features support #1345

Closed
kuwas opened this issue Dec 6, 2019 · 7 comments · Fixed by #1393
Closed

Feature Request > New branch protection features support #1345

kuwas opened this issue Dec 6, 2019 · 7 comments · Fixed by #1393

Comments

@kuwas
Copy link
Contributor

kuwas commented Dec 6, 2019

Hi,

Please add support for the new branch protection features:

  • required_linear_history
  • allow_force_pushes
  • allow_deletions

See: https://developer.github.com/v3/repos/branches/#update-branch-protection

Thanks!

@anorek
Copy link

anorek commented Dec 8, 2019

@gmlewis is this a feature that we would like to add, if so, could i try to work on this as a newb? 😃

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 8, 2019

Hi @anorek - I haven't had a chance to verify this one yet, so that would be the first step. So yes, it is yours. Thank you! 😁

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 24, 2019

I'm sorry, @anorek - it looks like @pcantea already submitted a PR for this.

@pcantea - in the future, could you please note in the issue (here) that you would like to work on it before sending a PR? It was already assigned to @anorek and if we communicate clearly, it can hopefully avoid developer frustration and prevent duplication of effort.

So @anorek - I hope you have not wasted too much time on this issue... but if you are OK with moving forward with @pcantea's PR in #1354, then that's how we'll proceed. I'll assume that so that we can hopefully keep moving forward and start reviewing the PR.

@anorek
Copy link

anorek commented Dec 24, 2019 via email

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 24, 2019

Thank you for your understanding, @anorek! Merry Christmas to you too!

@anorek
Copy link

anorek commented Dec 24, 2019

@gmlewis hey glen, just want to say that you are a wonderful maintainer! while I am grateful that you are such a hard worker and continue to create a good open source environment, I can only wish that you would be able to take the day off and enjoy the holiday and best of the health for you! ❤️

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 24, 2019

Thank you, @anorek, for the kind words! Best wishes to you too!

gmlewis pushed a commit that referenced this issue Jan 24, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this issue Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants