Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable gcloud tests for darwin #909

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

jonjohnsonjr
Copy link
Collaborator

Workaround for #908

@naveensrinivasan
Copy link

I was able to test it and it fixed the issue. Thanks

@naveensrinivasan
Copy link

Probably It would be good to include tests that target multiple OS. I can see if I can do that PR :)

@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #909 (ad5fe82) into master (7682012) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #909   +/-   ##
=======================================
  Coverage   72.57%   72.57%           
=======================================
  Files         108      108           
  Lines        4689     4689           
=======================================
  Hits         3403     3403           
  Misses        776      776           
  Partials      510      510           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7682012...ad5fe82. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit 96d4226 into google:master Jan 8, 2021
@jonjohnsonjr jonjohnsonjr deleted the disable-darwin branch January 8, 2021 22:41
@jonjohnsonjr
Copy link
Collaborator Author

Probably It would be good to include tests that target multiple OS. I can see if I can do that PR :)

I can't reproduce it myself, so I would really appreciate it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants