Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put k8schain in its own go module #904

Merged
merged 4 commits into from
Jan 11, 2021
Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr commented Jan 7, 2021

This should make go-containerregistry much easier to use.

#902
ko-build/ko#287
ko-build/ko#258 (comment)

WANT_LGTM=all

@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #904 (d7daec0) into master (f97c411) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
- Coverage   72.60%   72.57%   -0.04%     
==========================================
  Files         108      108              
  Lines        4687     4689       +2     
==========================================
  Hits         3403     3403              
- Misses        774      776       +2     
  Partials      510      510              
Impacted Files Coverage Δ
pkg/crane/digest.go 27.77% <0.00%> (-3.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f97c411...d7daec0. Read the comment docs.

@jonjohnsonjr
Copy link
Collaborator Author

Per https://pkg.go.dev/github.com/google/go-containerregistry/pkg/authn/k8schain?tab=importedby y'all might be affected.

cc @andreyvelich
cc @scothis
cc @matthewmcnew
cc @hasheddan
cc @davidewatson (also, https://github.com/davidewatson/keychain looks interesting, would love to see a README 😉)
cc @leogr

@jonjohnsonjr
Copy link
Collaborator Author

Split this up into two commits:

  1. go.mod changes, should be easy to review
  2. go mod tidy && go mod vendor

I didn't vendor the k8schain deps because I think it might break some expectations of various tools (only one top-level vendor/ directory). That's why there's the huge negative diff. Hopefully that's fine.

@mattmoor
Copy link
Collaborator

mattmoor commented Jan 8, 2021

Did you add any presubmit safeguard that the nested module files are correct?

@jonjohnsonjr
Copy link
Collaborator Author

cc @tejal29 as well

@jonjohnsonjr
Copy link
Collaborator Author

Did you add any presubmit safeguard that the nested module files are correct?

Done: 52dc010

Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonjohnsonjr! I'll test this out with our @crossplane usage 👍

@andreyvelich
Copy link

Thank you for the notice @jonjohnsonjr!
cc @gaocegege @johnugeorge

@@ -0,0 +1,23 @@
module github.com/google/go-containerregistry/pkg/authn/k8schain

go 1.15
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the parent is 1.14, these should be consistent.

Copy link
Collaborator Author

@jonjohnsonjr jonjohnsonjr Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be fine for them to diverge in the future, but I've dropped this to 1.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants