Implement partial.UncompressedSize #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
==========================================
+ Coverage 78.14% 78.37% +0.22%
==========================================
Files 102 102
Lines 4503 4517 +14
==========================================
+ Hits 3519 3540 +21
+ Misses 567 562 -5
+ Partials 417 415 -2
Continue to review full report at Codecov.
|
This allows access to an optional method that v1.Layers can implement to cheaply get the size of the uncompressed contents of a layer. This is useful in situations where you need to know the size of the contents before writing them (e.g. pkg/legacy/tarball.Write).
jonjohnsonjr
force-pushed
the
uncompressed-size
branch
from
303e951 to
863a871
Compare
jonjohnsonjr
force-pushed
the
uncompressed-size
branch
from
8fef1cb to
0c04e0d
Compare
smukherj1
approved these changes
Jan 15, 2020
jonjohnsonjr
force-pushed
the
uncompressed-size
branch
from
cf512f8 to
723a68c
Compare
smukherj1
added a commit
to smukherj1/rules_docker
that referenced
this pull request
Jan 15, 2020
Take advantage of google/go-containerregistry#655 and avoid loading an uncompressed layer into memory when writing out an image tarball.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows access to an optional method that v1.Layers can implement to
cheaply get the size of the uncompressed contents of a layer. This is
useful in situations where you need to know the size of the contents
before writing them (e.g. pkg/legacy/tarball.Write).
I dropped the
ReadAllcall in the "slow path". This means that theUncompressedbytes aren't buffered (yay), but if using a streaming layer, we might accidentally consume it. The only known uses of the legacy package don't use streaming layers, so we can cross that bridge when we get to it.