Add partial.Descriptor #654
Conversation
This consolidates a bit of logic for generating a v1.Descriptor, but also works around some of the nastiness that the partial package introduces. Because partial wraps layers and images with an extra level of implementation, it shadows any methods that the underlying object implements, so we can't expose "shortcuts". E.g. for tarball, we may want to expose the URLs from LayerSources to callers, but the partial wrapping gets in the way. This is going to be a useful pattern in general unless we get rid of the partial package entirely. Accessor methods that can introspect the (private) partial structs will be necessary if we want to support "optional" methods like UncompressedSize or Descriptor.
|
cc @smukherj1 |
|
We can use this pattern to add a Given the unfortunate nature of the tar format, we need to know the size of a layer before we can start writing it, which involves scanning the entire thing. There is some precedent for doing this in the standard library, e.g.
|
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
+ Coverage 77.8% 78.11% +0.31%
==========================================
Files 102 102
Lines 4500 4497 -3
==========================================
+ Hits 3501 3513 +12
+ Misses 583 567 -16
- Partials 416 417 +1
Continue to review full report at Codecov.
|
This consolidates a bit of logic for generating a v1.Descriptor, but
also works around some of the nastiness that the partial package
introduces.
Because partial wraps layers and images with an extra level of
implementation, it shadows any methods that the underlying object
implements, so we can't expose "shortcuts". E.g. for tarball, we may
want to expose the URLs from LayerSources to callers, but the partial
wrapping gets in the way.
This is going to be a useful pattern in general unless we get rid of the
partial package entirely. Accessor methods that can introspect the
(private) partial structs will be necessary if we want to support
"optional" methods like UncompressedSize or Descriptor.