Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement gc command #1811

Merged
merged 7 commits into from
Nov 29, 2023
Merged

feat: implement gc command #1811

merged 7 commits into from
Nov 29, 2023

Conversation

thesayyn
Copy link
Collaborator

@thesayyn thesayyn commented Oct 11, 2023

This is needed for a case where we use oci-layout as the registry storage directory and there are unreferenced blobs. We want to remove them during pull into the storage directory. I marked this as hidden to get some mileage in rules_oci.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (dbcd01c) 71.88% compared to head (fb8638f) 71.65%.
Report is 3 commits behind head on main.

❗ Current head fb8638f differs from pull request most recent head 6746d7f. Consider uploading reports for the commit 6746d7f to get more accurate results

Files Patch % Lines
pkg/v1/layout/gc.go 50.54% 30 Missing and 15 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1811      +/-   ##
==========================================
- Coverage   71.88%   71.65%   -0.24%     
==========================================
  Files         122      123       +1     
  Lines        9832     9928      +96     
==========================================
+ Hits         7068     7114      +46     
- Misses       2081     2115      +34     
- Partials      683      699      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/crane/cmd/pull.go Outdated Show resolved Hide resolved
@thesayyn
Copy link
Collaborator Author

Test failures seems unrelated. probably expired token.

@thesayyn thesayyn changed the title feat: implement prune flag feat: implement gc command Nov 21, 2023
@imjasonh imjasonh merged commit ceb0580 into google:main Nov 29, 2023
18 checks passed
maximilianbraun referenced this pull request in crossplane-contrib/xp-testing Dec 11, 2023
….17.0 (#35)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/google/go-containerregistry](https://togithub.com/google/go-containerregistry)
| require | minor | `v0.16.1` -> `v0.17.0` |

---

### Release Notes

<details>
<summary>google/go-containerregistry
(github.com/google/go-containerregistry)</summary>

###
[`v0.17.0`](https://togithub.com/google/go-containerregistry/releases/tag/v0.17.0)

[Compare
Source](https://togithub.com/google/go-containerregistry/compare/v0.16.1...v0.17.0)

#### What's Changed

- 🦅 Validate index architectures match children 🦅 by
[@&#8203;jonjohnsonjr](https://togithub.com/jonjohnsonjr) in
[https://github.com/google/go-containerregistry/pull/1776](https://togithub.com/google/go-containerregistry/pull/1776)
- Set Content-Length for blob uploads by
[@&#8203;jonjohnsonjr](https://togithub.com/jonjohnsonjr) in
[https://github.com/google/go-containerregistry/pull/1781](https://togithub.com/google/go-containerregistry/pull/1781)
- Don't wrap DefaultKeychain with refreshes by
[@&#8203;jonjohnsonjr](https://togithub.com/jonjohnsonjr) in
[https://github.com/google/go-containerregistry/pull/1791](https://togithub.com/google/go-containerregistry/pull/1791)
- Build releases with Go 1.21 by
[@&#8203;imjasonh](https://togithub.com/imjasonh) in
[https://github.com/google/go-containerregistry/pull/1840](https://togithub.com/google/go-containerregistry/pull/1840)
- fix: mimic oci-layout in diskblobhandler by
[@&#8203;thesayyn](https://togithub.com/thesayyn) in
[https://github.com/google/go-containerregistry/pull/1810](https://togithub.com/google/go-containerregistry/pull/1810)
- tag: add command explanation to the long help by
[@&#8203;abitrolly](https://togithub.com/abitrolly) in
[https://github.com/google/go-containerregistry/pull/1843](https://togithub.com/google/go-containerregistry/pull/1843)
- feat: implement gc command by
[@&#8203;thesayyn](https://togithub.com/thesayyn) in
[https://github.com/google/go-containerregistry/pull/1811](https://togithub.com/google/go-containerregistry/pull/1811)
- feat: allow port and disk path to be overriden by
[@&#8203;thesayyn](https://togithub.com/thesayyn) in
[https://github.com/google/go-containerregistry/pull/1848](https://togithub.com/google/go-containerregistry/pull/1848)

**Full Changelog**:
google/go-containerregistry@v0.16.1...v0.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/crossplane-contrib/xp-testing).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants