New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reporter verbosity bug #253

Merged

dsnet merged 1 commit into master from reporter-verbosity

Mar 3, 2021

Collaborator

dsnet commented Mar 3, 2021

FormatDiff should only set the verbosity to 3 if the current verbosity
is lower than 3. Otherwise, it may remove an intended higher verbosity
setting causing the reporter output to not differentiate between
two large values that are different at the end.

While we are at it, increase the maxVerbosityPreset to 6.

dsnet assigned neild

dsnet requested a review from neild

March 3, 2021 04:23

neild approved these changes

View reviewed changes


          Fix reporter verbosity bug

df549bd

FormatDiff should only set the verbosity to 3 if the current verbosity
is lower than 3. Otherwise, it may remove an intended higher verbosity
setting causing the reporter output to not differentiate between
two large values that are different at the end.

While we are at it, increase the maxVerbosityPreset to 6.

dsnet force-pushed the reporter-verbosity branch from b1938be to df549bd Compare

March 3, 2021 17:48

dsnet merged commit 8fa37b4 into master

dsnet deleted the reporter-verbosity branch

March 4, 2021 16:35

This was referenced Mar 6, 2021

Bump github.com/google/go-cmp from 0.4.0 to 0.5.5 coder/coder-v1-cli#266

Merged

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /sdk jmacd/opentelemetry-go#106

Open

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /detectors/gcp MrAlias/opentelemetry-go-contrib#633

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /propagators MrAlias/opentelemetry-go-contrib#653

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporters/metric/cortex MrAlias/opentelemetry-go-contrib#687

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /instrumentation/net/http/httptrace/otelhttptrace MrAlias/opentelemetry-go-contrib#694

Closed

Bump github.com/google/go-cmp from 0.5.2 to 0.5.5 in /exporters/otlp codeboten/opentelemetry-go#127

Closed

Bump github.com/google/go-cmp from 0.5.2 to 0.5.5 in /sdk codeboten/opentelemetry-go#131

Closed

Bump github.com/google/go-cmp from 0.5.2 to 0.5.5 codeboten/opentelemetry-go#132

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /detectors/gcp jmacd/opentelemetry-go-contrib#506

Open

Bump github.com/google/go-cmp from 0.5.2 to 0.5.5 in /exporters/trace/zipkin codeboten/opentelemetry-go#149

Closed

Bump github.com/google/go-cmp from 0.5.2 to 0.5.5 in /exporters/trace/jaeger codeboten/opentelemetry-go#151

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /propagators/opencensus MrAlias/opentelemetry-go-contrib#760

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 MadVikingGod/opentelemetry-go#9

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /sdk MadVikingGod/opentelemetry-go#32

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 atlassian-forks/opentelemetry-go#55

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /sdk atlassian-forks/opentelemetry-go#57

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporters/trace/zipkin MadVikingGod/opentelemetry-go#53

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporters/trace/zipkin atlassian-forks/opentelemetry-go#66

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporters/otlp atlassian-forks/opentelemetry-go#67

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporters/trace/jaeger atlassian-forks/opentelemetry-go#87

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporters/trace/jaeger MadVikingGod/opentelemetry-go#74

Closed

Bump github.com/google/go-cmp from 0.5.0 to 0.5.5 fakecoinbase/qlcchainslashgo-qlc#48

Closed

This was referenced Mar 8, 2021

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporter/jaegerthrifthttpexporter jmacd/opentelemetry-collector-contrib#700

Open

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /processor/metricstransformprocessor jmacd/opentelemetry-collector-contrib#702

Open

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 grafana/grafana-plugin-sdk-go#280

Merged

Bump github.com/google/go-cmp from 0.5.0 to 0.5.5 in /x/events blacklane/go-libs#45

Closed

Bump github.com/google/go-cmp from 0.5.0 to 0.5.5 in /tracking blacklane/go-libs#46

Closed

logger: bump github.com/google/go-cmp from 0.5.0 to 0.5.5. blacklane/go-libs#47

Closed

Bump github.com/google/go-cmp from 0.5.2 to 0.5.5 hashicorp/terraform-exec#140

Merged

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 yeya24/opentelemetry-collector#183

Closed

build(deps): Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporter/jaegerthrifthttpexporter dshomoye/opentelemetry-collector-contrib#23

Open

build(deps): Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporter/honeycombexporter dshomoye/opentelemetry-collector-contrib#25

Open

build(deps): Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /processor/metricstransformprocessor dshomoye/opentelemetry-collector-contrib#32

Closed

build(deps): Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporter/sentryexporter dshomoye/opentelemetry-collector-contrib#39

Closed

Bump github.com/google/go-cmp from 0.5.3 to 0.5.5 kisshang1993/v2ray-core#6

Closed

build(deps): Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /processor/metricstransformprocessor aabmass/opentelemetry-collector-contrib#11

Closed

build(deps): Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporter/honeycombexporter aabmass/opentelemetry-collector-contrib#27

Closed

build(deps): Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporter/sentryexporter aabmass/opentelemetry-collector-contrib#29

Closed

build(deps): Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporter/jaegerthrifthttpexporter aabmass/opentelemetry-collector-contrib#34

Closed

Chore(deps): Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 fmarslan/grafana#7

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporters/trace/zipkin johananl/opentelemetry-go#169

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporters/trace/jaeger srikanthccv/opentelemetry-go#133

Closed

This was referenced Mar 15, 2021

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporter/sentryexporter dynatrace-oss-contrib/opentelemetry-collector-contrib#733

Closed

build(deps): bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporter/jaegerthrifthttpexporter pmm-sumo/opentelemetry-collector-contrib#679

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporter/sentryexporter albertteoh/opentelemetry-collector-contrib#272

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 dashpole/opentelemetry-collector#46

Closed

build(deps): Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /processor/metricstransformprocessor newrelic-forks/opentelemetry-collector-contrib#25

Closed

build(deps): Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporter/honeycombexporter newrelic-forks/opentelemetry-collector-contrib#28

Closed

build(deps): Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporter/sentryexporter newrelic-forks/opentelemetry-collector-contrib#37

Closed

build(deps): Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 in /exporter/jaegerthrifthttpexporter newrelic-forks/opentelemetry-collector-contrib#53

Closed

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 kayac/ecspresso#258

Merged

Bump github.com/google/go-cmp from 0.5.4 to 0.5.5 jmacd/opentelemetry-collector#50

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet