Fix uint to format in decimal

[178inaba]

Since byte is an alias for uint8, format it in hex.

Fixes #185.

[dsnet]

Thanks for the PR. I feel like we should always use decimal except for []uint8. This is different from what this PR does, which is to just special-case uint8 by itself. It's still reasonable to use hexadecimal for uintptr.

[178inaba]

@dsnet Thanks for the review!
I found the case of isBinary.

go-cmp/cmp/report_slices.go

Lines 132 to 147 in 049b73f

	// If the text appears to be binary data,
	// then perform differencing in approximately fixed-sized chunks.
	// The output is inspired by hexdump.
	case isBinary:
	list = opts.formatDiffSlice(
	reflect.ValueOf(sx), reflect.ValueOf(sy), 16, "byte",
	func(v reflect.Value, d diffMode) textRecord {
	var ss []string
	for i := 0; i < v.Len(); i++ {
	ss = append(ss, formatHex(v.Index(i).Uint()))
	}
	s := strings.Join(ss, ", ")
	comment := commentString(fmt.Sprintf("%c|%v|", d, formatASCII(v.String())))
	return textRecord{Diff: d, Value: textLine(s), Comment: comment}
	},
	)

This seems to be the case when it is []byte and not unicode.

go-cmp/cmp/report_slices.go

Line 73 in 049b73f

case t.Kind() == reflect.Slice && t.Elem() == reflect.TypeOf(byte(0)):

go-cmp/cmp/report_slices.go

Line 87 in 049b73f

if !(unicode.IsPrint(r) || unicode.IsSpace(r)) || r == utf8.RuneError {

Should I format in hex only for isBinary and uintptr?

[178inaba]

@dsnet Hello!
I wrote the code to format only []uint8 type in hex.
Would you please review this pull request again?

[dsnet]

Overall looks good. Minor nits.

[dsnet]

(Stye-nit): Keep conditional as single line.

[dsnet]

Perhaps call this withinSlice instead (here and elsewhere)? Since we're usually looking at this variable from the perspective of the child.

[178inaba]

@dsnet Thank you for the review!
I fixed it!

[dsnet]

Thanks!

[dsnet]

Ooops. Forgot to merge it.