blob/fileblob: ignore URL's Host and drop leading / on Windows #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shantuo
reviewed
Nov 7, 2018
| // Host field, so URLs should always start with "file:///". On | ||
| // Windows, the leading "/" will be stripped, so "file:///c:/foo" | ||
| // will refer to c:/foo. | ||
| urlpath := url.PathEscape(filepath.ToSlash(dir)) |
There was a problem hiding this comment.
Should we handle converting separators to '/' in package fileblob instead of letting user to it? Is "c:\foo\bar" invalid?
There was a problem hiding this comment.
No; according to this, even on Windows, URLs referring to files should use "/" as a path separator. So doing this on the user side is correct.
That said, it might work either way; i.e., if they pass file:///c:\foo\bar.txt, it might work. "" is definitely illegal in the host part, which is why the test was failing before, but it might be legal in the path part, and we are just passing the path through to OpenBucket. I don't want to document it as working though., and the example should do the correct thing.
shantuo
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be more correct than including the Host as part of the string we pass
OpenBucket, based on my reading of https://en.wikipedia.org/wiki/File_URI_scheme. Dealing with file-based URLs in Windows is pretty hokey, but it's clear you have to drop the leading "/".blob/example_test.gopasses on Windows after these changes.