Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/all: disable Upload optimization when WriterOptions.ContentMD5 is set #3478

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Aug 20, 2024

Fixes #3477.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.07%. Comparing base (7a096fb) to head (f4dd7c4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3478   +/-   ##
=======================================
  Coverage   73.07%   73.07%           
=======================================
  Files         113      113           
  Lines       14979    14980    +1     
=======================================
+ Hits        10946    10947    +1     
  Misses       3270     3270           
  Partials      763      763           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangent vangent merged commit 54419b7 into google:master Aug 20, 2024
6 checks passed
@vangent vangent deleted the uploadfix branch August 21, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blob: Bucket.Upload() does not compute md5
1 participant