Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/requestlog: Don't consume entire body just to get a request size #3274

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Jul 19, 2023

Fixes #2848.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #3274 (1b0154d) into master (8cab06e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3274      +/-   ##
==========================================
- Coverage   77.54%   77.53%   -0.02%     
==========================================
  Files         104      104              
  Lines       13718    13718              
==========================================
- Hits        10638    10636       -2     
- Misses       2343     2346       +3     
+ Partials      737      736       -1     
Impacted Files Coverage Δ
server/requestlog/requestlog.go 70.45% <100.00%> (-4.55%) ⬇️

... and 2 files with indirect coverage changes

@vangent vangent merged commit 8d4590a into google:master Jul 19, 2023
@vangent vangent deleted the svr branch July 19, 2023 20:06
ybourgery pushed a commit to Simprints/go-cloud that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server/requestlog: request logging unconditionally consumes entire body
1 participant