Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: add ErrorAs #1197

Merged
merged 5 commits into from
Jan 30, 2019
Merged

pubsub: add ErrorAs #1197

merged 5 commits into from
Jan 30, 2019

Conversation

jba
Copy link
Contributor

@jba jba commented Jan 26, 2019

  • Add an ErrorAs method to Topic and Subscription.
  • Add it to drivers as well.
  • Write test.

Fixes #957.

@jba jba requested review from ijt and vangent January 26, 2019 00:09
@googlebot googlebot added the cla: yes Google CLA has been signed! label Jan 26, 2019
vangent
vangent requested changes Jan 26, 2019
View reviewed changes
pubsub/drivertest/drivertest.go Show resolved Hide resolved
pubsub/pubsub.go Show resolved Hide resolved
pubsub/rabbitpubsub/rabbit.go Outdated Show resolved Hide resolved
ijt
ijt suggested changes Jan 26, 2019
View reviewed changes
pubsub/gcppubsub/gcppubsub.go Outdated Show resolved Hide resolved
pubsub/rabbitpubsub/rabbit.go Outdated Show resolved Hide resolved
@jba
Copy link
Contributor Author

jba commented Jan 28, 2019

PTAL.

vangent
vangent approved these changes Jan 28, 2019
View reviewed changes
pubsub/rabbitpubsub/doc.go Outdated Show resolved Hide resolved
@jba
Copy link
Contributor Author

jba commented Jan 28, 2019

PTAL @ijt

@jba
Copy link
Contributor Author

jba commented Jan 30, 2019

@ijt ping

@jba jba merged commit b4346d1 into google:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vangent vangent vangent approved these changes

@ijt ijt ijt approved these changes

Assignees

@ijt ijt

@vangent vangent

Labels
cla: yes Google CLA has been signed!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jba @ijt @vangent @googlebot