Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64-Bit Windows Fixes #93

Closed
wants to merge 4 commits into from
Closed

64-Bit Windows Fixes #93

wants to merge 4 commits into from

Conversation

artemdinaburg
Copy link

This makes unit tests pass on 64-bit Windows by comparing %p format strings via a special token. On 64-bit Windows, %p is always zero-padded to 16 characters. This change should be helpful in general, since %p is implementation defined.

Also #define some constants in windows/port.h to their underscore prefixed versions, as the non-underscore versions are deprecated.

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@artemdinaburg
Copy link
Author

Hi,

This PR should be cla:yes. The commit CLAbot is saying "no" for is by an author that accepted the CLA and has just been merged into glog mainline (#123).

@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@jakirkham
Copy link

Any news on this PR? Doesn't appear to have been review. 😕

@sergiud
Copy link
Collaborator

sergiud commented Nov 4, 2017

@artemdinaburg Could you please remove the commits not authored by you and squash the remaining ones?

As far as I can tell, the last commit in the PR has been already merged. Also, please update your email address in your commit such that the bot can detect that you already signed the CLA.

@sergiud sergiud requested review from sergiud and removed request for sergiud November 4, 2017 15:29
@sergiud sergiud self-assigned this Nov 4, 2017
@jakirkham
Copy link

Sorry seems I caused some confusion with my comment. I didn't open this PR or add commits to it. Just was eager to see it reviewed.

@sergiud
Copy link
Collaborator

sergiud commented Nov 4, 2017

@jakirkham My bad. I actually wanted to address @artemdinaburg. Thanks for pointing it out.

@jakirkham
Copy link

No worries. Thanks for taking a look. 🙂

@NeroBurner
Copy link
Contributor

Changes merged with #331 please close this PR

@sergiud sergiud closed this Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants