Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about dragons in the Bazel include path #927

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Warn about dragons in the Bazel include path #927

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e71d2b
Warn about dragons in the Bazel `include` path
drigz May 31, 2023
9d970f7
Explain why strip_include_prefix works
drigz Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions bazel/glog.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,12 @@ def glog_library(namespace = "google", with_gflags = 1, **kwargs):
":stl_logging_h",
":vlog_is_on_h",
],
# https://github.com/google/glog/issues/837: Replacing
# `strip_include_prefix` with `includes` would avoid spamming
# downstream projects with compiler warnings, but would also leak
# private headers like stacktrace.h. I suspect the only way to avoid
# this is to refactor the project including the CMake build, so that
# the private headers are in a glog_internal subdirectory.
strip_include_prefix = "src",
defines = final_lib_defines,
copts = final_lib_copts,
Expand Down