Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling mistakes #919

Merged
merged 1 commit into from
May 25, 2023
Merged

Fix spelling mistakes #919

merged 1 commit into from
May 25, 2023

Conversation

Vertexwahn
Copy link
Contributor

Fix spelling mistakes

@Vertexwahn
Copy link
Contributor Author

@drigz Can you merge this PR?

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Merging #919 (22cb44e) into master (6742834) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
- Coverage   73.85%   73.57%   -0.28%     
==========================================
  Files          17       17              
  Lines        3251     3251              
==========================================
- Hits         2401     2392       -9     
- Misses        850      859       +9     
Impacted Files Coverage Δ
src/demangle.cc 97.47% <ø> (ø)
src/glog/logging.h.in 80.28% <ø> (ø)
src/utilities.h 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@drigz
Copy link
Member

drigz commented May 25, 2023

Can I ask why you're sending this PR? These mistakes seem harmless, the PR is also harmless, but it costs time for the maintainer to validate that it's not changing behavior, so I wonder if it's worth creating such PRs in future for projects that you are not already contributing to.

For example (and I know this might sound petty but it's the sad reality of my mindset) I am "only" the maintainer of the Bazel integration in this repository, so I need to decide whether this is likely to be outside my territory, or whether I would just annoy the primary maintainer by assigning it to them.

@Vertexwahn
Copy link
Contributor Author

@drigz Ok will not reopen similar PRs again. Feel free to close the PR - or I can close it...

@drigz
Copy link
Member

drigz commented May 25, 2023

NP, I think this is a net improvement so I suspect it's best to merge. Sorry if I came across as standoffish, and I hope this doesn't put you off making bug fixes or other contributions in future!

@drigz drigz merged commit 4945347 into google:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants