Allow updating vmodule levels after vmodule level has been cached #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sergiud I can not see why windows build is failing and I do not have a windows machine to test it. Could you help pointing out the problem? |
|
Thanks for the PR. I will look into the failures. The |
|
The test fails because |
sergiud
reviewed
May 14, 2021
romange
force-pushed
the
Prod
branch
2 times, most recently
from
e6e93d6
to
4f4190a
Compare
…ready cached site flags vmodule flag is relevant for GNUC environments only.
|
@sergiud it should pass now. PTAL |
|
Thanks! |
stdpain
added a commit
to stdpain/starrocks-2
that referenced
this pull request
Jul 12, 2024
upgrade brpc to 1.9.0 upgrade glog to 0.7.1 brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md we could use brpc async interface instead of using thread pool simulate an async interface glog has support change vlog level dynamic in google/glog#650 Signed-off-by: stdpain <[email protected]>
stdpain
added a commit
to stdpain/starrocks-2
that referenced
this pull request
Jul 12, 2024
upgrade brpc to 1.9.0 upgrade glog to 0.7.1 brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md we could use brpc async interface instead of using thread pool simulate an async interface glog has support change vlog level dynamic in google/glog#650 Signed-off-by: stdpain <[email protected]>
stdpain
added a commit
to stdpain/starrocks-2
that referenced
this pull request
Jul 12, 2024
upgrade brpc to 1.9.0 upgrade glog to 0.7.1 brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md we could use brpc async interface instead of using thread pool simulate an async interface glog has support change vlog level dynamic in google/glog#650 Signed-off-by: stdpain <[email protected]>
stdpain
added a commit
to stdpain/starrocks-2
that referenced
this pull request
Jul 12, 2024
upgrade brpc to 1.9.0 upgrade glog to 0.7.1 brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md we could use brpc async interface instead of using thread pool simulate an async interface glog has support change vlog level dynamic in google/glog#650 Signed-off-by: stdpain <[email protected]>
stdpain
added a commit
to stdpain/starrocks-2
that referenced
this pull request
Jul 12, 2024
upgrade brpc to 1.9.0 upgrade glog to 0.7.1 brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md we could use brpc async interface instead of using thread pool simulate an async interface glog has support change vlog level dynamic in google/glog#650 Signed-off-by: stdpain <[email protected]>
stdpain
added a commit
to stdpain/starrocks-2
that referenced
this pull request
Jul 12, 2024
upgrade brpc to 1.9.0 upgrade glog to 0.7.1 brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md we could use brpc async interface instead of using thread pool simulate an async interface glog has support change vlog level dynamic in google/glog#650 Signed-off-by: stdpain <[email protected]>
stdpain
added a commit
to stdpain/starrocks-2
that referenced
this pull request
Jul 12, 2024
upgrade brpc to 1.9.0 upgrade glog to 0.7.1 brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md we could use brpc async interface instead of using thread pool simulate an async interface glog has support change vlog level dynamic in google/glog#650 Signed-off-by: stdpain <[email protected]>
kevincai
pushed a commit
to kevincai/starrocks
that referenced
this pull request
Jul 25, 2024
upgrade brpc to 1.9.0 upgrade glog to 0.7.1 brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md we could use brpc async interface instead of using thread pool simulate an async interface glog has support change vlog level dynamic in google/glog#650 Signed-off-by: stdpain <[email protected]>
kevincai
pushed a commit
to kevincai/starrocks
that referenced
this pull request
Jul 29, 2024
upgrade brpc to 1.9.0 upgrade glog to 0.7.1 brpc has support thrift extends https://github.com/apache/brpc/blob/master/docs/en/thrift.md we could use brpc async interface instead of using thread pool simulate an async interface glog has support change vlog level dynamic in google/glog#650 Signed-off-by: stdpain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We maintain a linked list of all sites so we could invalidate those that should change upon SetVLOGLevel call.
Once site level starts pointing to module override it will be removed from the linked list to avoid unnecessary traversals.
Fixes #649