Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make symbolize.cc thread safe even on shared fds #388

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Make symbolize.cc thread safe even on shared fds #388

merged 1 commit into from
Nov 14, 2018

Commits on Nov 13, 2018

  1. Make symbolize.cc thread safe even on shared fds 

    ReadFromOffset in symbolize.cc used to call lseek() + read() to read
data from fd. However, the fd may be reused for multiple symbolize
requests from multiple threads, and causes a race around the fd read
offset.

This updates it to use pread() to resolve the race.
    @tzik
    tzik committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    1081df6 View commit details
    Browse the repository at this point in the history