Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing exports (fixes #227) #228

Merged
merged 1 commit into from
Aug 9, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/glog/logging.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -931,7 +931,8 @@ struct CompileAssert {
struct CrashReason;

// Returns true if FailureSignalHandler is installed.
bool IsFailureSignalHandlerInstalled();
// Needs to be exported since it's used by the signalhandler_unittest.
GOOGLE_GLOG_DLL_DECL bool IsFailureSignalHandlerInstalled();
} // namespace glog_internal_namespace_

#define GOOGLE_GLOG_COMPILE_ASSERT(expr, msg) \
Expand Down
3 changes: 2 additions & 1 deletion src/stacktrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
#define BASE_STACKTRACE_H_

#include "config.h"
#include "glog/logging.h"

_START_GOOGLE_NAMESPACE_

Expand All @@ -53,7 +54,7 @@ _START_GOOGLE_NAMESPACE_
// .... ...
//
// "result" must not be NULL.
extern int GetStackTrace(void** result, int max_depth, int skip_count);
GOOGLE_GLOG_DLL_DECL int GetStackTrace(void** result, int max_depth, int skip_count);

_END_GOOGLE_NAMESPACE_

Expand Down
1 change: 0 additions & 1 deletion src/stacktrace_windows-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@

_START_GOOGLE_NAMESPACE_

GOOGLE_GLOG_DLL_DECL
int GetStackTrace(void** result, int max_depth, int skip_count) {
if (max_depth > 64) {
max_depth = 64;
Expand Down
2 changes: 1 addition & 1 deletion src/symbolize.h
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ _START_GOOGLE_NAMESPACE_
// symbol name to "out". The symbol name is demangled if possible
// (supports symbols generated by GCC 3.x or newer). Otherwise,
// returns false.
bool Symbolize(void *pc, char *out, int out_size);
GOOGLE_GLOG_DLL_DECL bool Symbolize(void *pc, char *out, int out_size);

_END_GOOGLE_NAMESPACE_

Expand Down