Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symbolize detection on macOS #1138

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

take-cheeze
Copy link
Contributor

Since by detecting as UNIX first will end up as Linux: https://cmake.org/cmake/help/latest/variable/UNIX.html

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.73%. Comparing base (2075ae8) to head (77665b0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
- Coverage   64.03%   63.73%   -0.30%     
==========================================
  Files          20       20              
  Lines        2580     2606      +26     
  Branches      888      903      +15     
==========================================
+ Hits         1652     1661       +9     
- Misses        663      677      +14     
- Partials      265      268       +3     

see 9 files with indirect coverage changes

@take-cheeze
Copy link
Contributor Author

@sergiud sergiud added the bug label Nov 5, 2024
@sergiud
Copy link
Collaborator

sergiud commented Nov 5, 2024

Thanks!

@sergiud sergiud merged commit 1f0f3d6 into google:master Nov 5, 2024
136 checks passed
@take-cheeze take-cheeze deleted the sym_app branch November 5, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants