Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow setting stderrthreshold using GLOG_stderrthreshold #1034

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Jan 5, 2024

Fixes #558

@sergiud sergiud added the bug label Jan 5, 2024
@sergiud sergiud added this to the 0.7 milestone Jan 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8fbad2c) 59.21% compared to head (2501f99) 59.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
- Coverage   59.21%   59.18%   -0.03%     
==========================================
  Files          19       19              
  Lines        2540     2541       +1     
  Branches      907      908       +1     
==========================================
  Hits         1504     1504              
  Misses        693      693              
- Partials      343      344       +1     
Files Coverage Δ
src/flags.cc 26.82% <0.00%> (-0.68%) ⬇️

@sergiud sergiud merged commit b172be9 into master Jan 5, 2024
268 checks passed
@sergiud sergiud deleted the stderrthreshold-glog-env branch January 5, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot pass stderrthreshold as environment variable
2 participants