Add override to LogStreamBuf::overflow()

Prevents warnings such as: ``` glog/logging.h:1122:20: error: ‘virtual std::basic_streambuf<char>::int_type google::base_logging::LogStreamBuf::overflow(std::basic_streambuf<char>::int_type)’ can be marked override [-Werror=suggest-override] virtual int_type overflow(int_type ch) { ^~~~~~~~ ``` Signed-off-by: Santiago Gil <[email protected]>
google · Sep 14, 2020 · f79373f · f79373f
1 parent 0a2e593
commit f79373f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/glog/logging.h.in b/src/glog/logging.h.in
@@ -1128,7 +1128,7 @@ class GOOGLE_GLOG_DLL_DECL LogStreamBuf : public std::streambuf {
   }
 
   // This effectively ignores overflow.
-  virtual int_type overflow(int_type ch) {
+  virtual int_type overflow(int_type ch) override {
     return ch;
   }
 

diff --git a/src/windows/glog/logging.h b/src/windows/glog/logging.h
@@ -1129,7 +1129,7 @@ class GOOGLE_GLOG_DLL_DECL LogStreamBuf : public std::streambuf {
   }
 
   // This effectively ignores overflow.
-  virtual int_type overflow(int_type ch) {
+  virtual int_type overflow(int_type ch) override {
     return ch;
   }