Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup libafl_fuzzbench-based fuzzers #2032

Merged
merged 6 commits into from
Sep 19, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- libxslt_xpath
- mbedtls_fuzz_dtlsclient
- mbedtls_fuzz_dtlsclient_7c6b0e
- mruby_mruby_fuzzer
- mruby_mruby_fuzzer_8c8bbd
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonggeLiu Maybe something worth noting: the CI will not fail if the benchmark doesn't exist!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I did not know this, thanks!
I reckon this is low priority because it does not affect checking fuzzers or running experiments.
WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon it's low priority as well, but maybe something to keep in mind since it might inadvertently mark a fuzzer as "working" for a non-existent benchmark.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, created this: #2037

- openh264_decoder_fuzzer
- openssl_x509
- openthread_ot-ip6-send-fuzzer
Expand Down
Loading