Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libafl-based fuzzers (from AFL++ fork) #2027

Merged
merged 11 commits into from
Aug 16, 2024
Merged

Update libafl-based fuzzers (from AFL++ fork) #2027

merged 11 commits into from
Aug 16, 2024

Conversation

addisoncrump
Copy link
Contributor

Changing forks so @tokatoka can collab with me on this. Supercedes #2021.

@addisoncrump addisoncrump mentioned this pull request Aug 14, 2024
Closed
@addisoncrump
Copy link
Contributor Author

@DonggeLiu When possible, could you please run a short experiment to see if the CI is spuriously failing? I think this will still be affected by #2023.

@tokatoka
Copy link
Contributor

are you sure 799c634fef047d3e98355fe1ad17c5226c901a57 is the right commit?

@addisoncrump
Copy link
Contributor Author

That was the state of main when I checked it... I also tested this locally.

@tokatoka
Copy link
Contributor

and it looks like the problem is from libafl_text we should drop it

@addisoncrump
Copy link
Contributor Author

Didn't know if we still cared about libafl_text 😅 I can delete.

@addisoncrump addisoncrump mentioned this pull request Aug 14, 2024
Closed
@addisoncrump addisoncrump marked this pull request as draft August 14, 2024 16:53
@DonggeLiu
Copy link
Contributor

/gcbrun run_experiment.py -a --experiment-config /opt/fuzzbench/service/experiment-config.yaml --experiment-name 2024-08-15-2027-1 --fuzzers libafl libafl_libfuzzer

@DonggeLiu
Copy link
Contributor

Experiment 2024-08-15-2027-1 data and results will be available later at:
The experiment data.
The experiment report.
The experiment report(experimental).

@tokatoka
Copy link
Contributor

idk we only got data for two of the fuzzers?

@tokatoka
Copy link
Contributor

wait but they do have the result for the 30 minutes run in the experiment-data, so everything is working i guess

addisoncrump
addisoncrump commented Aug 15, 2024
View reviewed changes
benchmarks/harfbuzz_hb-shape-fuzzer_17863b/build.sh
Comment on lines -28 to +29
export CFLAGS="$CFLAGS -fno-sanitize=vptr -DHB_NO_VISIBILITY"
export CXXFLAGS="$CXXFLAGS -fno-sanitize=vptr -DHB_NO_VISIBILITY"
export CFLAGS="$CFLAGS -fno-sanitize=vptr -DHB_NO_VISIBILITY -DHB_NO_PRAGMA_GCC_DIAGNOSTIC -Wno-cast-function-type-strict -Wno-incompatible-function-pointer-types-strict"
export CXXFLAGS="$CXXFLAGS -fno-sanitize=vptr -DHB_NO_VISIBILITY -DHB_NO_PRAGMA_GCC_DIAGNOSTIC -Wno-cast-function-type-strict -Wno-incompatible-function-pointer-types-strict"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should now work for all clang-based fuzzers.

@tokatoka
Copy link
Contributor

so it's ready to merge?

@addisoncrump
Copy link
Contributor Author

Somehow the php bug benchmark has bitrotted during this PR!

I'll revert the experiment-relevant changes and then yes, it'll be good to go.

@DonggeLiu DonggeLiu marked this pull request as ready for review August 16, 2024 00:45
@DonggeLiu
Copy link
Contributor

Strangely FuzzBench reports libafl failed to build with some benchmarks, but the build log says otherwise:
image
But I don't think this relates to this PR, so let's merge.

Similarly, there are some coverage run failures, but it should not block this PR either:
image

DonggeLiu
DonggeLiu approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@DonggeLiu DonggeLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both for updating libafl and libafl_libfuzzer : )

@DonggeLiu DonggeLiu merged commit e72f5bb into google:master Aug 16, 2024
30 of 31 checks passed
ardier pushed a commit to ardier/fuzzbench that referenced this pull request Nov 25, 2024
@addisoncrump
Update libafl-based fuzzers (from AFL++ fork) (google#2027)
fa33c8e 
Changing forks so @tokatoka can collab with me on this. Supercedes
google#2021.
As requested in google#2020.
ardier pushed a commit to ardier/fuzzbench that referenced this pull request Nov 25, 2024
@addisoncrump
Update libafl-based fuzzers (from AFL++ fork) (google#2027)
e915adb 
Changing forks so @tokatoka can collab with me on this. Supercedes
As requested in google#2020.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonggeLiu DonggeLiu DonggeLiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addisoncrump @tokatoka @DonggeLiu