Libafl forkserver test #1585
Merged
Libafl forkserver test #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bug based benchmarks is extremely broken now. |
Every benchmark? Just 2 or 3 would be fine. presubmit doesn't fail locally and it seems to fail a test that is (probably) unrelated to my PR. |
|
Do you know the last working commit? At least I can rebase on it and run on a subset of the programs locally |
|
Do you want to run this now? I think we're in better shape |
No for a strange reason some benchmarks don't build with afl++ under libafl_forkserver, I'm trying to figure out why, I'll remove the draft mark when ready |
|
@jonathanmetzman ok to merge now, bug benchs build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we added the support to run AFL++ binaries in LibAFL with CmpLog and shmem inputs.
With this PR, I'm requesting a bug-based benchmark (as the advantage of the forkserver is reliability even when the target is crashing often) to test if the Rust implementation matches the original C version of AFL++ in code and bug coverage.
Related to this, #1584