Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not report unused args as errors #1559

Merged
merged 3 commits into from
Nov 23, 2022

Conversation

DonggeLiu
Copy link
Contributor

Some projects use -Werror to turn all warnings into errors.
This affects Centipede as we do not separate build and linking flags as it expects, which leads to unused-command-line-argument warnings.
This PR disables turning that specific warning into errors and keeps the rest the same.

See the same PR from OSS-Fuzz for more info and the error in this PR for its use case.

@DonggeLiu
Copy link
Contributor Author

DonggeLiu commented Nov 23, 2022

This PR adds a new flag (i.e., -Wno-error=unused-command-line-argument) to make benchmarksystemd_fuzz-varlink compatible with Centipede, yet systemd_fuzz-link-parser still fails for the same old reason.
This is because the latter adds another-Werror=unused-command-line-argument at the end of our flags, which specifically overwrites the flag added in this PR.
We could use a wrapper to remove that or reorder the flags (e.g., put ours at the end).

@DonggeLiu
Copy link
Contributor Author

TBR.

@DonggeLiu DonggeLiu merged commit 3878b68 into upgrade-base-image Nov 23, 2022
@DonggeLiu DonggeLiu deleted the ignore_centipede_unused_build_args branch November 23, 2022 11:53
Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants