Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint #1529

Merged
merged 29 commits into from
Nov 24, 2022
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
766c155
Update pylintrc
DonggeLiu Oct 18, 2022
21eb884
Fixing lint-1
DonggeLiu Oct 18, 2022
a65abf4
Fix lint-2
DonggeLiu Oct 18, 2022
b72f5df
Fix lint-3
DonggeLiu Oct 18, 2022
5a0c56b
Fix lint-4
DonggeLiu Oct 18, 2022
82f9967
Fix lint-5
DonggeLiu Oct 18, 2022
d1a935a
Fix lint-6
DonggeLiu Oct 19, 2022
f91a7b2
Manually merge pylintrc
DonggeLiu Oct 20, 2022
152d85a
Fix lint: Long url
DonggeLiu Oct 20, 2022
fbf0929
Fix lint: long lines
DonggeLiu Oct 20, 2022
7c58854
Fix lint: using with
DonggeLiu Oct 20, 2022
16618a9
Fix lint: lint comment
DonggeLiu Oct 20, 2022
4d5dec3
Merge branch 'upgrade-base-image' into fix_lint
DonggeLiu Oct 20, 2022
ad05bef
Fix naming
DonggeLiu Oct 20, 2022
5bb981c
Ignore/fix lint in framework
DonggeLiu Oct 21, 2022
939dfbc
Leftover lint errors
DonggeLiu Oct 21, 2022
1012bda
Minor format change
DonggeLiu Oct 21, 2022
2323d97
Ignore temporary fuzzers
DonggeLiu Oct 21, 2022
967550b
Fix lint-7
DonggeLiu Oct 21, 2022
dcef066
Fix lint: URL
DonggeLiu Oct 21, 2022
80d0be4
Fix lint: with-Popen
DonggeLiu Oct 21, 2022
dbe5889
Add fuzzers to fuzzer list
DonggeLiu Oct 21, 2022
0013e16
A todo
DonggeLiu Oct 24, 2022
6f3f16a
Remove redundant pylint comments
DonggeLiu Oct 25, 2022
e4cb11f
End log with .
DonggeLiu Oct 25, 2022
7a412cc
Unify quotes
DonggeLiu Oct 25, 2022
02fe2a8
Revert "Add fuzzers to fuzzer list"
DonggeLiu Oct 25, 2022
71ff5c6
Merge branch 'master' into fix_lint
DonggeLiu Oct 26, 2022
30ab028
Merge branch 'upgrade-base-image' into fix_lint
DonggeLiu Nov 24, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build_and_test_run_fuzzer_benchmarks.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def make_builds(benchmarks, fuzzer):
# Sort benchmarks so that they get built in a deterministic order.
fuzzer_benchmark_pairs = sorted(fuzzer_benchmark_pairs,
key=lambda pair: pair[1])
print('Building fuzzer-benchmark pairs: {}'.format(fuzzer_benchmark_pairs))
print(f'Building fuzzer-benchmark pairs: {fuzzer_benchmark_pairs}')
for _, benchmark in fuzzer_benchmark_pairs:
make_target = get_make_target(fuzzer, benchmark)
make_command = ['make', 'RUNNING_ON_CI=yes', '-j', make_target]
Expand All @@ -116,7 +116,7 @@ def do_build(build_type, fuzzer, always_build):
elif build_type == 'bug':
benchmarks = benchmark_utils.get_bug_benchmarks()
else:
raise Exception('Invalid build_type: %s' % build_type)
raise Exception(f'Invalid build_type: {build_type}')

if always_build:
# Always do a build if always_build is True.
Expand All @@ -138,7 +138,7 @@ def do_build(build_type, fuzzer, always_build):
def main():
"""Build OSS-Fuzz or standard benchmarks with a fuzzer."""
if len(sys.argv) != 3:
print('Usage: %s <build_type> <fuzzer>' % sys.argv[0])
print(f'Usage: {sys.argv[0]} <build_type> <fuzzer>')
return 1
build_type = sys.argv[1]
fuzzer = sys.argv[2]
Expand Down
Loading