Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow per-directory overrides #7191

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .ci/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,12 @@ def main():

for directory, check_type in directory_check_types(args.branch):
out = os.path.join("out", os.path.basename(directory))
fontbakery = ["--fontbakery"]
fbconfig = os.path.join(directory, "fontbakery.yml")
if os.path.exists(fbconfig):
fontbakery += ["--extra-fontbakery-args=--configuration",
f"--extra-fontbakery-args={fbconfig}"]

fonts = glob(os.path.join(directory, "*.ttf"))

qa_cmd_prefix = ["gftools", "qa", "-f"] + fonts + ["-o", out]
Expand All @@ -123,15 +129,15 @@ def main():

elif check_type == CheckType.NEW_FAMILY:
print(f"Checking new family: {directory}")
subprocess.run(qa_cmd_prefix + ["--fontbakery", "--interpolations"])
subprocess.run(qa_cmd_prefix + fontbakery + ["--interpolations"])

elif check_type == CheckType.MODIFIED_FAMILY:
print(f"Checking modified family: {directory}")
subprocess.run(qa_cmd_prefix + ["-gfb", "--fontbakery", "--diffenator", "--interpolations"])
subprocess.run(qa_cmd_prefix + ["-gfb"] + fontbakery + ["--diffenator", "--interpolations"])

elif check_type == CheckType.MODIFIED_FAMILY_METADATA:
print(f"Checking modified family metadata: {directory}")
subprocess.run(qa_cmd_prefix + ["--fontbakery", "-o", out])
subprocess.run(qa_cmd_prefix + fontbakery + ["-o", out])

elif check_type == CheckType.DESIGNER:
print(f"Checking designer profile: {directory}")
Expand Down
2 changes: 1 addition & 1 deletion ofl/pushster/METADATA.pb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ fonts {
filename: "Pushster-Regular.ttf"
post_script_name: "Pushster-Regular"
full_name: "Pushster Regular"
copyright: "Copyright 2010 xyz The Lobster Project Authors (https://github.com/impallari/The-Lobster-Font), with Reserved Font Name \"Lobster\".4"
copyright: "Copyright 2010 xyz The Lobster Project Authors (https://github.com/impallari/The-Lobster-Font), with Reserved Font Name \"Lobster\".5"
}
subsets: "latin"
subsets: "latin-ext"
Expand Down
7 changes: 7 additions & 0 deletions ofl/pushster/fontbakery.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
exclude_checks:
- com.google.fonts/check/soft_dotted
- com.google.fonts/check/glyphsets/shape_languages

overrides:
com.google.fonts/check/outline_jaggy_segments:
found-jaggy-segments: INFO