Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sixtyfour: Version 2.000;gftools[0.9.33] added #6919

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

vv-monsalve
Copy link
Collaborator

d82ab2b: [gftools-packager] Sixtyfour: Version 2.000;gftools[0.9.33] added

@github-actions

This comment was marked as outdated.

@vv-monsalve vv-monsalve linked an issue Oct 26, 2023 that may be closed by this pull request
7 tasks
@github-actions

This comment was marked as outdated.

@vv-monsalve
Copy link
Collaborator Author

vv-monsalve commented Oct 26, 2023

  • 🔥 FAIL: Does DESCRIPTION file contain broken links?

The link will exist when #6917 is merged. We should remember to counter-check the link once in prod.

  • 🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field.

I've inspected the links in METADATA and DESCRIPTION files, and they both use https://github.com/jenskutilek/homecomputer-fonts. So not clear why is this Fail reported.

  • 🔥 FAIL: Check Google Fonts glyph coverage.
  • 🔥 FAIL: Check font follows the Google Fonts vertical metric schema

Due to the historic origin of the fonts it was agreed to accept these fails.

  • 🔥 FAIL: Check variable font instances

Given the font only includes custom axes it is accepted for them to include custom named instances. After Kablammo's case this was confirmed for the homecomputer fonts. I need to include this to the GF-Guide

  • 🔥 FAIL: Check a font's STAT table contains compulsory Axis Values.

Bug reported in googlefonts/axisregistry#99 (comment)

  • 🔥 FAIL: Validate METADATA.pb axes tags are defined in gf_axisregistry.

The SCAN and BLED axes were already merged in the googlefonts/axisregistry repo and will be brought with an upcoming git subtree pull. Please only merge this PR once I create that git subtree pull. I'll inform you about it

  • ⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog?

Waiting for the designer's info to add his entry to the catalog.

@vv-monsalve vv-monsalve marked this pull request as draft October 26, 2023 23:27
@vv-monsalve
Copy link
Collaborator Author

Updated

Sixtyfour: Version 2.000 added


64e7c16: [gftools-packager] Sixtyfour: Version 2.000 added

@vv-monsalve
Copy link
Collaborator Author

Designer Jens Kutílek was added in #6935

Copy link

github-actions bot commented Nov 2, 2023

FontBakery report

fontbakery version: 0.10.3

[1] Experimental checks
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 🔥 FAIL GF_Latin_Kernel/kl_Latn (Kalaallisut): [FAIL: Some mark glyphs were missing: ◌̀, ◌́, ◌̂, ◌̃, ◌̊] [code: failed-language-shaping]
  • 🔥 FAIL GF_Latin_Kernel/zu_Latn (Zulu): [FAIL: Some mark glyphs were missing: ◌̀, ◌́, ◌̂, ◌̃, ◌̄, ◌̆, ◌̈, ◌̊, ◌̧] [code: failed-language-shaping]

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('SCAN-BLED', 1) [code: summary]


[17] Sixtyfour[BLED,SCAN].ttf
🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0308 (COMBINING DIAERESIS)

    • 0x0300 (COMBINING GRAVE ACCENT)

    • 0x0301 (COMBINING ACUTE ACCENT)

    • 0x030B (COMBINING DOUBLE ACUTE ACCENT)

    • 0x0304 (COMBINING MACRON)

    • 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)

    • 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)

    • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

    • 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)

    • 0x010C (LATIN CAPITAL LETTER C WITH CARON)

    • 117 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)
  • 🔥 FAIL Compulsory STAT Axis Values are incorrect:
Name Axis Current Value Current Flags Current LinkedValue Expected Value Expected Flags Expected LinkedValue
Regular wght N/A N/A N/A 400.0 0 700.0
[code: bad-axis-values]
🔥 FAIL: Check variable font instances (com.google.fonts/check/fvar_instances)
  • 🔥 FAIL fvar instances are incorrect:
  • Delete additional instances
Name current expected
Slight SCAN=-45.0, BLED=0.0 N/A
Delicate SCAN=-53.0, BLED=0.0 N/A
Evenly SCAN=-27.0, BLED=0.0 N/A
Overlapping SCAN=37.0, BLED=0.0 N/A
Maximum SCAN=100.0, BLED=0.0 N/A
Overexposed SCAN=67.0, BLED=0.0 N/A
Touching SCAN=21.0, BLED=0.0 N/A
Regular SCAN=0.0, BLED=0.0 SCAN=0.0, BLED=0.0
🔥 FAIL: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
  • 🔥 FAIL The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 1024 when it should be at least 1228 [code: bad-hhea-range]
🔥 FAIL: Validate METADATA.pb axes tags are defined in gf_axisregistry. (com.google.fonts/check/metadata/gf_axisregistry_valid_tags)
  • 🔥 FAIL The font variation axis 'BLED' is not yet registered on Google Fonts Axis Registry. [code: bad-axis-tag]
  • 🔥 FAIL The font variation axis 'SCAN' is not yet registered on Google Fonts Axis Registry. [code: bad-axis-tag]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+2021 DOUBLE DAGGER: try adding adlam

  • U+2030 PER MILLE SIGN: try adding adlam

  • U+2126 OHM SIGN: not included in any glyphset definition

  • U+2501 BOX DRAWINGS HEAVY HORIZONTAL: not included in any glyphset definition

  • U+2503 BOX DRAWINGS HEAVY VERTICAL: not included in any glyphset definition

  • U+250F BOX DRAWINGS HEAVY DOWN AND RIGHT: not included in any glyphset definition

  • U+2513 BOX DRAWINGS HEAVY DOWN AND LEFT: not included in any glyphset definition

  • U+2517 BOX DRAWINGS HEAVY UP AND RIGHT: not included in any glyphset definition

  • U+251B BOX DRAWINGS HEAVY UP AND LEFT: not included in any glyphset definition
    200 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]

WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Jens Kutílek is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/sixtyfour/Sixtyfour[BLED,SCAN].ttf
Dehinted Size 69.9kb
Hinted Size 69.9kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.000"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • INFO Latn [code: dlng-tag]
  • INFO Latn [code: slng-tag]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/sixtyfour [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 7 2 55 10 181 0
0% 3% 1% 22% 4% 71% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve vv-monsalve marked this pull request as ready for review November 2, 2023 22:25
@vv-monsalve vv-monsalve added the -- Requires Axis Registration Variable axes are not yet registered label Nov 2, 2023
@vv-monsalve vv-monsalve removed the -- Requires Axis Registration Variable axes are not yet registered label Nov 9, 2023
Copy link

FontBakery report

fontbakery version: 0.10.3

[1] Experimental checks
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 🔥 FAIL GF_Latin_Kernel/kl_Latn (Kalaallisut): [FAIL: Some mark glyphs were missing: ◌̀, ◌́, ◌̂, ◌̃, ◌̊] [code: failed-language-shaping]
  • 🔥 FAIL GF_Latin_Kernel/zu_Latn (Zulu): [FAIL: Some mark glyphs were missing: ◌̀, ◌́, ◌̂, ◌̃, ◌̄, ◌̆, ◌̈, ◌̊, ◌̧] [code: failed-language-shaping]

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('SCAN-BLED', 1) [code: summary]


[17] Sixtyfour[BLED,SCAN].ttf
🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0308 (COMBINING DIAERESIS)

    • 0x0300 (COMBINING GRAVE ACCENT)

    • 0x0301 (COMBINING ACUTE ACCENT)

    • 0x030B (COMBINING DOUBLE ACUTE ACCENT)

    • 0x0304 (COMBINING MACRON)

    • 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)

    • 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)

    • 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)

    • 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)

    • 0x010C (LATIN CAPITAL LETTER C WITH CARON)

    • 117 more.

Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]

🔥 FAIL: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)
  • 🔥 FAIL Compulsory STAT Axis Values are incorrect:
Name Axis Current Value Current Flags Current LinkedValue Expected Value Expected Flags Expected LinkedValue
Regular wght N/A N/A N/A 400.0 0 700.0
[code: bad-axis-values]
🔥 FAIL: Check variable font instances (com.google.fonts/check/fvar_instances)
  • 🔥 FAIL fvar instances are incorrect:
  • Delete additional instances
Name current expected
Delicate SCAN=-53.0, BLED=0.0 N/A
Maximum SCAN=100.0, BLED=0.0 N/A
Evenly SCAN=-27.0, BLED=0.0 N/A
Touching SCAN=21.0, BLED=0.0 N/A
Slight SCAN=-45.0, BLED=0.0 N/A
Overexposed SCAN=67.0, BLED=0.0 N/A
Overlapping SCAN=37.0, BLED=0.0 N/A
Regular SCAN=0.0, BLED=0.0 SCAN=0.0, BLED=0.0
🔥 FAIL: Check font follows the Google Fonts vertical metric schema (com.google.fonts/check/vertical_metrics)
  • 🔥 FAIL The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 1024 when it should be at least 1228 [code: bad-hhea-range]
🔥 FAIL: Validate METADATA.pb axes tags are defined in gf_axisregistry. (com.google.fonts/check/metadata/gf_axisregistry_valid_tags)
  • 🔥 FAIL The font variation axis 'BLED' is not yet registered on Google Fonts Axis Registry. [code: bad-axis-tag]
  • 🔥 FAIL The font variation axis 'SCAN' is not yet registered on Google Fonts Axis Registry. [code: bad-axis-tag]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

  • U+2021 DOUBLE DAGGER: try adding adlam

  • U+2030 PER MILLE SIGN: try adding adlam

  • U+2126 OHM SIGN: not included in any glyphset definition

  • U+2501 BOX DRAWINGS HEAVY HORIZONTAL: not included in any glyphset definition

  • U+2503 BOX DRAWINGS HEAVY VERTICAL: not included in any glyphset definition

  • U+250F BOX DRAWINGS HEAVY DOWN AND RIGHT: not included in any glyphset definition

  • U+2513 BOX DRAWINGS HEAVY DOWN AND LEFT: not included in any glyphset definition

  • U+2517 BOX DRAWINGS HEAVY UP AND RIGHT: not included in any glyphset definition

  • U+251B BOX DRAWINGS HEAVY UP AND LEFT: not included in any glyphset definition
    200 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]

WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Jens Kutílek is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/sixtyfour/Sixtyfour[BLED,SCAN].ttf
Dehinted Size 69.9kb
Hinted Size 69.9kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 2.000"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • INFO Latn [code: dlng-tag]
  • INFO Latn [code: slng-tag]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/sixtyfour [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 7 2 55 10 181 0
0% 3% 1% 22% 4% 71% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner
Copy link
Contributor

After discussing the axes with @vv-monsalve, we decided to merge the PR so see how they render in sandbox but she would make a new PR where "Close" is elided in the STAT table for better cross-platform naming consistency.

@RosaWagner RosaWagner merged commit b75cf66 into main Nov 15, 2023
9 checks passed
@RosaWagner RosaWagner deleted the gftools_packager_ofl_sixtyfour branch November 15, 2023 14:15
@vv-monsalve
Copy link
Collaborator Author

Revising the above and taking Kablammo as a benchmark (of a font with only custom axes) I've changed the current Regular fvar table to Close. This way, the fvar matches the STAT table while not making any instance convey the "weight" axis.

I've created a new PR to the upstream repo. Will update this PR once it's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Homecomputer VF fonts
3 participants