Mekorot: Version 2.000;gftools[0.9.32] added

[eliheuer]

5a7d05a: [gftools-packager] Mekorot: Version 2.000;gftools[0.9.32] added

• Mekorot Version 2.000;gftools[0.9.32] taken from the upstream repo https://github.com/googlefonts/mekorot at commit googlefonts/mekorot@1d4d2d4.

[github-actions]

Fontbakery report

Fontbakery version: 0.8.13

[1] Family checks

ℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)

• ℹ INFO From a total of 2 font files, 0 of them (0.00%) lack a STAT table.

  And these are the most common STAT axis orderings:
  ('wght-ital', 2) [code: summary]

[20] Mekorot-Italic[wght].ttf

⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)

• ⚠ WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
  [code: unknown]

⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)

• ⚠ WARN The following codepoints supported by the font are not covered by
  any subsets defined in the font's metadata file, and will never
  be served. You can solve this by either manually adding additional
  subset declarations to METADATA.pb, or by editing the glyphset
  definitions.

• U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi

• U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

• U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

• U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

• U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, cherokee, coptic, math

• U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

• U+0307 COMBINING DOT ABOVE: try adding one of: tai-le, malayalam, syriac, old-permic, tifinagh, coptic, math, canadian-aboriginal

• U+030A COMBINING RING ABOVE: try adding syriac

• U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage

• U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  55 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic-ext, greek-ext, hebrew, latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]

⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)

• ⚠ WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]

⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)

• ⚠ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]

⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)

• ⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:

  • f + f

  • f + i

  • i + f

  • f + l

  • l + f

  • i + j

  • j + l

  • l + t [code: lacks-kern-info]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)

• ⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]

⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)

• ⚠ WARN It seems that Alan Hoenig is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]

⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)

• ⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]

⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)

• ⚠ WARN The following glyphs could not be reached by codepoint or substitution rules:

  • CR

  • acutedotaccent

  • blacktriangle

  • breveacute

  • brevegrave

  • brevehookabove

  • brevetilde

  • carondotaccent

  • circumflexhookabove

  • circumflextilde

  • 39 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

⚠ WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)

• ⚠ WARN This font has a 'Soft Hyphen' character. [code: softhyphen]

⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)

• ⚠ WARN No dotted circle glyph present [code: missing-dotted-circle]

⚠ WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)

• ⚠ WARN Interpolation issues were found in the font: - Contour order differs in glyph 'uni03020300': [0, 1] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7ff824940e50>, [1, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7ff824940fa0>.

  • Contour order differs in glyph 'uni2016': [0, 1] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7ff824940e50>, [1, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7ff824940fa0>.

  • Contour 2 start point differs in glyph 'uni2116' between location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7ff824940e50> and location <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7ff824940fa0> [code: interpolation-issues]

ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)

• ℹ INFO Found a git repo URL: https://github.com/googlefonts/mekorot [code: url-found]

ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)

• ℹ INFO Hinting filesize impact:

	ofl/mekorot/Mekorot-Italic[wght].ttf
Dehinted Size	131.0kb
Hinted Size	131.0kb
Increase	24 bytes
Change	0.0 %
[code: size-impact]

ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)

• ℹ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000;gftools[0.9.32]'] [code: version-not-detected]

ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)

• ℹ INFO EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818 [code: lacks-EPAR]

ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)

• ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)

• ℹ INFO Version string is: "Version 2.000;gftools[0.9.32]"
  The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
  "Version 1.3; git-0d08353-release" [code: bad-format]

ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

• ℹ INFO This font contains the following optional tables:

  • loca

  • prep

  • GPOS

  • GSUB

  • gasp [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)

• ℹ INFO ofl/mekorot [code: family-path]

[20] Mekorot[wght].ttf

⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)

• ⚠ WARN OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
  [code: unknown]

⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)

• ⚠ WARN The following codepoints supported by the font are not covered by
  any subsets defined in the font's metadata file, and will never
  be served. You can solve this by either manually adding additional
  subset declarations to METADATA.pb, or by editing the glyphset
  definitions.

• U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi

• U+02D8 BREVE: try adding one of: yi, canadian-aboriginal

• U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal

• U+02DB OGONEK: try adding one of: yi, canadian-aboriginal

• U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, cherokee, coptic, math

• U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic

• U+0307 COMBINING DOT ABOVE: try adding one of: tai-le, malayalam, syriac, old-permic, tifinagh, coptic, math, canadian-aboriginal

• U+030A COMBINING RING ABOVE: try adding syriac

• U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage

• U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  55 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic-ext, greek-ext, hebrew, latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]

⚠ WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)

• ⚠ WARN This font lacks caret position values for ligature glyphs on its GDEF table. [code: lacks-caret-pos]

⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)

• ⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:

  • f + f

  • f + i

  • i + f

  • f + l

  • l + f

  • i + j

  • j + l

  • l + t [code: lacks-kern-info]

⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)

• ⚠ WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]

⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)

• ⚠ WARN It seems that Alan Hoenig is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]

⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)

• ⚠ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]

⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)

• ⚠ WARN The following glyphs could not be reached by codepoint or substitution rules:

  • CR

  • acutedotaccent

  • blacktriangle

  • breveacute

  • brevegrave

  • brevehookabove

  • brevetilde

  • carondotaccent

  • circumflexhookabove

  • circumflextilde

  • 39 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

⚠ WARN: Does the font contain a soft hyphen? (com.google.fonts/check/soft_hyphen)

• ⚠ WARN This font has a 'Soft Hyphen' character. [code: softhyphen]

⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)

• ⚠ WARN No dotted circle glyph present [code: missing-dotted-circle]

⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)

• ⚠ WARN The dot of soft dotted characters should disappear in other cases, for example: ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ ȉ̦ ȋ̦ i̦̒ j̦̀ j̦́ ĵ̦ j̦̃ j̦̄ j̦̆ j̦̇ j̦̈ j̦̉ j̦̊ j̦̋ ǰ̦ [code: soft-dotted]

⚠ WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)

• ⚠ WARN Interpolation issues were found in the font: - Contour order differs in glyph 'uni2016': [0, 1] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7ff825920850>, [1, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7ff8259207f0>. [code: interpolation-issues]

ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)

• ℹ INFO Found a git repo URL: https://github.com/googlefonts/mekorot [code: url-found]

ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)

• ℹ INFO Hinting filesize impact:

	ofl/mekorot/Mekorot[wght].ttf
Dehinted Size	117.7kb
Hinted Size	117.8kb
Increase	24 bytes
Change	0.0 %
[code: size-impact]

ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)

• ℹ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000;gftools[0.9.32]'] [code: version-not-detected]

ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)

• ℹ INFO EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818 [code: lacks-EPAR]

ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)

• ℹ INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)

• ℹ INFO Version string is: "Version 2.000;gftools[0.9.32]"
  The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
  "Version 1.3; git-0d08353-release" [code: bad-format]

ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)

• ℹ INFO This font contains the following optional tables:

  • loca

  • prep

  • GPOS

  • GSUB

  • gasp [code: optional-tables]

ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)

• ℹ INFO ofl/mekorot [code: family-path]

Summary

💔 ERROR	🔥 FAIL	⚠ WARN	💤 SKIP	ℹ INFO	🍞 PASS	🔎 DEBUG
0	0	24	82	17	352	0
0%	0%	5%	17%	4%	74%	0%

Note: The following loglevels were omitted in this report:

• SKIP
• PASS
• DEBUG

[eliheuer]

This is for issue: #3363

[RosaWagner]

Thanks @eliheuer, I noticed the Hebrew is quite darker than the latin, is there a rational for that choice (to add eventually in the description)?

In terms of subsets.

1. Should we set the hebrew as the primary script? It means the specimen page will show mostly hebrew.
2. Is it necessary to include vietnamese? If users want an extended latin set, they may as well use Spectral directly. I would personally only include Latin Core like we do for Noto to preserve some file size. Or some scaling was performed on Spectral?
3. In METADATA.pb, it is curious these subsets were included: "cyrillic-ext" "greek-ext", looking at the glyphset, we can certainly remove them. Did packager included them automatically?

Shall we fix the latin a bit?

I mostly spotted some spacing/kerning irregularities from Spectral. We can either fix them or ignore since the Hebrew is most important script here.

Dot should be in the middle of two L or l. You can give a negative sidebearing to periodcentered.loclCAT to achieve that.

[davelab6]

Should we set the hebrew as the primary script? It means the specimen page will show mostly hebrew.

Yes, I think so

Is it necessary to include vietnamese?

Only including Latin Core sgtm

[RosaWagner]

@eliheuer the questions I asked in my last review have not all been answered. What is the status of Mekorot? From what Dave answered, we can ignore the kerning issues in spectral since the primary script is Hebrew, the most important thing to correct is the weight matching between latin and hebrew.

[eliheuer]

@RosaWagner The weight matching between Latin and Hebrew is the most difficult thing to update, I'm working on it.

It's a heavy Hebrew font at the regular weight, if I make the regular Latin too bold, it basically has no latin regular, and only has bold and bolder.

For interlinear use it makes sense to have a regular Latin that is not too bold.

If I made the regular Latin bold to match the weight of the Hebrew, it would become a worse font for it's intended purpose, which is the kind of typesetting you see in the images below.

Note the weight difference between the Hebrew and Latin in these examples, I am not saying that this PR can not be improved, the weight difference is better in these example images, just that getting it right is tricky and requires some thought: