Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arima: Version 1.101;gftools[0.9.23] added #5914

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Conversation

yanone
Copy link
Collaborator

@yanone yanone commented Feb 21, 2023

711e318: [gftools-packager] Arima: Version 1.101;gftools[0.9.23] added

@yanone yanone linked an issue Feb 21, 2023 that may be closed by this pull request
@yanone yanone added I Small Fix bugs fixed but nothing added III Improve rendering / layout by addition of manual hinting, kerning or else - Ready for Review labels Feb 21, 2023
@github-actions
Copy link

Fontbakery report

Fontbakery version: 0.8.10

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('wght', 1) [code: summary]


[23] Arima[wght].ttf
🔥 FAIL: Check Google Fonts glyph coverage. (com.google.fonts/check/glyph_coverage)
  • 🔥 FAIL Missing required codepoints:

    • 0x0132 (LATIN CAPITAL LIGATURE IJ)

    • 0x014A (LATIN CAPITAL LETTER ENG)

    • 0x0133 (LATIN SMALL LIGATURE IJ)

    • And 0x014B (LATIN SMALL LETTER ENG)
      [code: missing-codepoints]

🔥 FAIL: Validates that when an instance record is included for the default instance, its subfamilyNameID value is set to either 2 or 17 (or something with the same value as 2), and its postScriptNameID value is set to 6 (or something with the same value as 6). (com.adobe.fonts/check/varfont/valid_default_instance_nameids)
  • 🔥 FAIL 'Thin' instance has the same coordinates as the default instance; its subfamily name should be 'Regular' [code: invalid-default-instance-subfamily-nameid:260]
WARN: DESCRIPTION.en_us.html should end in a linebreak. (com.google.fonts/check/description/eof_linebreak)
  • WARN The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it. [code: missing-eof-linebreak]
WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'NDIS' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13] [code: http-in-description]
  • WARN Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=14] [code: http-in-license-info]
  • WARN For now we're still accepting http URLs, but you should consider using https instead.
    [code: http]
WARN: Are there caret positions declared for every ligature? (com.google.fonts/check/ligature_carets)
  • WARN This font lacks caret positioning values for these ligature glyphs:

    • fi
    • fl

    [code: incomplete-caret-pos-data]

WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + i

    • And i + l [code: lacks-kern-info]

WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
  • WARN Please consider adding a subdirectory called "static/" and including in it static font files. [code: missing]
WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Rosalie Wagner is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • G_tildecomb

    • NULL

    • acutecomb.cap

    • dotbelowcomb.cap

    • g_tildecomb

    • gravecomb.cap

    • rr_rramalayalam.below

    • sh_ra_iiMatratamil

    • tildecomb.cap

    • uni006B0BB7

    • And 33 more.

Use -F or --full-lists to disable shortening of long lists.
[code: unreachable-glyphs]

WARN: Check glyphs in mark glyph class are non-spacing. (com.google.fonts/check/gdef_spacing_marks)
  • WARN The following spacing glyphs may be in the GDEF mark glyph class by mistake:
    uMatra_halantmalayalam (unencoded), uni0D02 (U+0D02), uni0D03 (U+0D03), uni0D3E (U+0D3E), uni0D3F (U+0D3F), uni0D40 (U+0D40), uni0D41 (U+0D41), uni0D42 (U+0D42), uni0D43 (U+0D43), uni0D44 (U+0D44) and 7 more.

Use -F or --full-lists to disable shortening of long lists. [code: spacing-mark-glyphs]

WARN: Check GDEF mark glyph class doesn't have characters that are not marks. (com.google.fonts/check/gdef_non_mark_chars)
  • WARN The following non-mark characters should not be in the GDEF mark glyph class:
    U+0D02, U+0D03, U+0D3E, U+0D3F, U+0D40, U+0D46, U+0D47, U+0D48, U+0D4A, U+0D4B, U+0D4C and U+0D57 [code: non-mark-chars]
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/arima/Arima[wght].ttf
Dehinted Size 340.3kb
Hinted Size 340.3kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.101;gftools[0.9.23]'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 1.101;gftools[0.9.23]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
  • INFO No sample_glyphs on METADATA.pb [code: no-samples]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • GPOS

    • GSUB

    • And gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/arima [code: family-path]

### Summary
💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 2 12 46 10 157 0
0% 1% 5% 20% 4% 69% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@yanone
Copy link
Collaborator Author

yanone commented Feb 21, 2023

I don't get the invalid-default-instance-subfamily-nameid FAIL when checking locally with the latest fontbakery.
Please also ignore the missing codepoints FAIL as this is a rendering bug update.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Feb 21, 2023

@yanone the Malayalam has changed a fair bit. I don't know the script so I cannot confirm whether the changes are good or not?

@m4rc1e
Copy link
Collaborator

m4rc1e commented Feb 21, 2023

Here's a gif which compares a fallback font against the latest Arima. The latest Arima imo looks broken against the fallback

malay.mp4

@yanone
Copy link
Collaborator Author

yanone commented Feb 21, 2023

Can you please copy/paste the text that you used?

@m4rc1e
Copy link
Collaborator

m4rc1e commented Feb 21, 2023

പരസ്പരം ഇഷ്ടമല്ല

Take a look at the Regular diffenator report which the CI has generated for this PR.

@yanone
Copy link
Collaborator Author

yanone commented Feb 21, 2023

Can't explain it myself. Posted an issue: NDISCOVER/Arima-Font#36

@yanone
Copy link
Collaborator Author

yanone commented Feb 23, 2023

Response from author: Rendering is good an in accordance to script reform.

Please proceed with the publication.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Feb 23, 2023

Thanks Yanone. I'll still bring this up in the management meeting later today.

@m4rc1e
Copy link
Collaborator

m4rc1e commented Feb 23, 2023

We're happy so I'll take one last later on.

@m4rc1e m4rc1e merged commit 2b48c42 into main Feb 23, 2023
@m4rc1e m4rc1e deleted the gftools_packager_ofl_arima branch February 23, 2023 16:13
@RosaWagner RosaWagner added --- Live Font is visible on API and removed --- to production labels Apr 6, 2023
@RosaWagner RosaWagner removed the --- Live Font is visible on API label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Small Fix bugs fixed but nothing added III Improve rendering / layout by addition of manual hinting, kerning or else
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Fix Arima rendering issue
3 participants