Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Why Flax NNX guide #4262

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Update Why Flax NNX guide #4262

merged 2 commits into from
Oct 10, 2024

Conversation

8bitmp3
Copy link
Collaborator

@8bitmp3 8bitmp3 commented Oct 7, 2024

@8bitmp3 8bitmp3 requested review from cgarciae and IvyZX October 7, 2024 21:04
@8bitmp3 8bitmp3 self-assigned this Oct 7, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 8, 2024

Why Flax NNX is now in the reRestructuredText format instead of Markdown.

Changing the format.

@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 8, 2024

Rebasing, then reopening the PR.

@8bitmp3 8bitmp3 changed the title Light update to Why Flax NNX guide Update Why Flax NNX guide Oct 8, 2024
@8bitmp3 8bitmp3 reopened this Oct 8, 2024
@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 9, 2024

🤔 RTD build failures cc @cgarciae

@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 9, 2024

Removing the legacy quick_start to fix the RTF test, as discussed @IvyZX @cgarciae

@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 9, 2024

Fixing how a numbered list (1.... 2.... 3...) is rendered.

Copy link
Collaborator

@IvyZX IvyZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A bunch more nits and thoughts. Overall good!

docs_nnx/why.rst Outdated Show resolved Hide resolved
docs_nnx/why.rst Outdated Show resolved Hide resolved
docs_nnx/why.rst Outdated Show resolved Hide resolved
docs_nnx/why.rst Show resolved Hide resolved
docs_nnx/why.rst Outdated Show resolved Hide resolved
@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 10, 2024

Just waiting for the preview to complete.
https://readthedocs.org/projects/flax/builds/25896179/

@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 10, 2024

thanks!

@copybara-service copybara-service bot merged commit 53ba626 into google:main Oct 10, 2024
17 checks passed
@8bitmp3 8bitmp3 deleted the fixes-nnx-1 branch October 10, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants