Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes definition of
_ParentType
so that runtime type checkers work with nested Flax modules.What does this PR do?
Fixes #3756. The parents that
_ParentType
refers to are instances of classes, not the classes themselves, sotype[Module]
andtype[_Sentinel]
should becomeModule
and_Sentinel
respectively.Checklist
checks if that's the case).