Rename nnx.compat to nnx.bridge
#4066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4066 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 106 107 +1
Lines 13582 13825 +243
======================================
- Misses 13582 13825 +243 ☔ View full report in Codecov by Sentry. |
cgarciae
reviewed
Jul 10, 2024
| from .nnx import graph as graph | ||
| from .nnx import errors as errors | ||
| from .nnx import helpers as helpers | ||
| from .nnx import compat as compat | ||
| from .nnx import bridge as bridge | ||
| compat = bridge # Make the old import name still work |
There was a problem hiding this comment.
we should consider just removing this to take advantage of the fact that we don't have users yet
There was a problem hiding this comment.
Good idea - done in the final merged version.
cgarciae
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid any future confusion of
compatvscompact.