[linen] allows multiple compact methods #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
linen-allow-multi-compact
branch
2 times, most recently
from
1a54215
to
9d624cc
Compare
|
Hi there @cgarciae, how far off is this from getting merged & released. I'd love to be able to mark multiple methods as compact. Cheers! |
|
@ZacCranko sorry this has taken so long! Let me test it against our internal code. |
cgarciae
force-pushed
the
linen-allow-multi-compact
branch
from
9d624cc
to
1b85693
Compare
cgarciae
force-pushed
the
linen-allow-multi-compact
branch
from
1b85693
to
86292dd
Compare
cgarciae
force-pushed
the
linen-allow-multi-compact
branch
from
86292dd
to
1f29197
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows multiple compact methods to be used in a single Module. However, its up to the user to guarantee that auto-naming collisions don't occur between different
applycalls using different call paths.