Remove the uninitialized field "embedding" in nn.Embed #3801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3801 +/- ##
==========================================
- Coverage 60.34% 60.31% -0.03%
==========================================
Files 101 101
Lines 12862 12860 -2
==========================================
- Hits 7761 7756 -5
- Misses 5101 5104 +3 ☔ View full report in Codecov by Sentry. |
copybara-service
bot
force-pushed
the
test_620422049
branch
from
b256256
to
9a2a4d6
Compare
The presence of this field breaks dataclasses.asdict() but it doesn't seem to serve much purpose. It was added in a change that tries to reduce gpylint errors but removing this line does not trigger any new gpylint error. PiperOrigin-RevId: 620934766
copybara-service
bot
force-pushed
the
test_620422049
branch
from
9a2a4d6
to
f2bdcd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the uninitialized field "embedding" in nn.Embed
The presence of this field breaks dataclasses.asdict() but it doesn't seem to serve much purpose. It was added in a change that tries to reduce gpylint errors but removing this line does not trigger any new gpylint error.