Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nnx] add GraphNode base class #3790

Merged
merged 1 commit into from
Mar 27, 2024
Merged

[nnx] add GraphNode base class #3790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion flax/experimental/nnx/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@
from .nnx.module import GraphDef as GraphDef
from .nnx.module import M as M
from .nnx.module import Module as Module
from .nnx.module import merge as merge
from .nnx.graph_utils import merge as merge
from .nnx.graph_utils import split as split
from .nnx.graph_utils import update as update
from .nnx.nn import initializers as initializers
from .nnx.nn.activations import celu as celu
from .nnx.nn.activations import elu as elu
Expand Down
2 changes: 1 addition & 1 deletion flax/experimental/nnx/examples/toy_examples/06_scan_over_layers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def create_block(keys):

# call vmap over create_block, passing the split `params` key
# and immediately merge to get a Block instance
self.layers = nnx.merge(jax.vmap(create_block)(keys))
self.layers = nnx.merge(*jax.vmap(create_block)(keys))

def __call__(self, x: jax.Array, *, rngs: nnx.Rngs) -> jax.Array:
# fork Rngs, split keys into `n_layers`
Expand Down
2 changes: 1 addition & 1 deletion flax/experimental/nnx/examples/toy_examples/07_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ def __init__(self, cfg: Config, *, rngs: nnx.Rngs):

if cfg.scanned:
self.layers = nnx.merge(
jax.vmap(lambda key: DecoderBlock(cfg, rngs=nnx.Rngs(key)).split())(
*jax.vmap(lambda key: DecoderBlock(cfg, rngs=nnx.Rngs(key)).split())(
jax.random.split(rngs.params(), cfg.layers)
)
)
Expand Down
Loading
Loading