Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git fetch upstream to contributing doc. #3757

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Add git fetch upstream to contributing doc. #3757

merged 1 commit into from
Mar 14, 2024

Conversation

carlosgmartin
Copy link
Contributor

In the contributing doc, change

git rebase upstream/main

to

git fetch upstream
git rebase upstream/main

This ensures that users fetch upstream before rebasing. I had to do this for #3712 and prior PRs. It also matches JAX's contributing doc.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.70%. Comparing base (3da44bc) to head (84809ef).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3757   +/-   ##
=======================================
  Coverage   58.70%   58.70%           
=======================================
  Files         102      102           
  Lines       12412    12412           
=======================================
  Hits         7286     7286           
  Misses       5126     5126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgarciae
Copy link
Collaborator

Thanks @carlosgmartin !

@copybara-service copybara-service bot merged commit c2af614 into google:main Mar 14, 2024
19 checks passed
@carlosgmartin carlosgmartin deleted the contributing_git_fetch branch March 14, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants