nn.jit: automatic fingerprint definition for dataclass attributes #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
jit-fingerprint
branch
3 times, most recently
from
1fd55a1
to
2f2b755
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3737 +/- ##
==========================================
+ Coverage 58.63% 58.67% +0.03%
==========================================
Files 103 103
Lines 12379 12386 +7
==========================================
+ Hits 7259 7267 +8
+ Misses 5120 5119 -1 ☔ View full report in Codecov by Sentry. |
cgarciae
force-pushed
the
jit-fingerprint
branch
5 times, most recently
from
5abdc08
to
001df6c
Compare
chiamp
reviewed
Mar 5, 2024
| f"type '{x}' is not hashable. Unhashable fields: {unhashable_paths}" | ||
| ) | ||
| try: | ||
| hash(x) |
There was a problem hiding this comment.
would isinstance(x, typing.Hashable) work instead of a try-catch block?
There was a problem hiding this comment.
Nope. Having a __hash__ method is not enough.
chiamp
reviewed
Mar 5, 2024
flax/linen/transforms.py
Outdated
| ) -> tuple[type[Any], Any]: | ||
| def _fingerprint_recursive( | ||
| obj: Any, path: tuple[str, ...], seen_modules: dict[FlaxId, int] | ||
| ) -> Any: | ||
| """Creates a hashable representation for a Module by travering its structure recursively.""" |
There was a problem hiding this comment.
Suggested change
| """Creates a hashable representation for a Module by travering its structure recursively.""" | |
| """Creates a hashable representation for a Module by traversing its structure recursively.""" |
chiamp
approved these changes
Mar 5, 2024
cgarciae
force-pushed
the
jit-fingerprint
branch
from
001df6c
to
3ea30d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Defines a fingerprint for dataclass attributes to avoid the use of
unsafe_hash.