Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broadcast of strides and kernel_dilation to nn.ConvTranspose #3731

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

IvyZX
Copy link
Collaborator

@IvyZX IvyZX commented Mar 1, 2024

Fixes #3729 and make the API of nn.Conv and nn.ConvTranspose more consistent.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 59.00%. Comparing base (f5c48fe) to head (fdbc640).
Report is 2 commits behind head on main.

Files Patch % Lines
flax/linen/linear.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3731      +/-   ##
==========================================
- Coverage   59.09%   59.00%   -0.09%     
==========================================
  Files         103      103              
  Lines       12456    12422      -34     
==========================================
- Hits         7361     7330      -31     
+ Misses       5095     5092       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IvyZX IvyZX requested review from chiamp and levskaya March 1, 2024 03:36
@IvyZX IvyZX self-assigned this Mar 1, 2024
@copybara-service copybara-service bot merged commit 1abfa87 into google:main Mar 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify behavior of strides arg of Conv and ConvTranspose
3 participants