Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated nnx compute_stats #3693

Merged
merged 1 commit into from
Feb 14, 2024
Merged

updated nnx compute_stats #3693

merged 1 commit into from
Feb 14, 2024

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Feb 14, 2024 •
edited
Loading

Resolves #3690.

Added fast_variance and mask options to NNX _compute_stats.

Added fast_variance to Linen's RMSNorm

@chiamp chiamp self-assigned this Feb 14, 2024
@chiamp chiamp requested a review from cgarciae February 14, 2024 00:45
cgarciae
cgarciae approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@cgarciae cgarciae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome @chiamp! thanks for doing this :)

@copybara-service copybara-service bot merged commit d061da8 into google:main Feb 14, 2024
19 checks passed
@chiamp chiamp deleted the nnx_compute_stats branch February 15, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgarciae cgarciae cgarciae approved these changes

Assignees

@chiamp chiamp

Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NNX _compute_stats function missing use_fast_variance and mask argument
2 participants
@chiamp @cgarciae