Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scan out_axes #3540

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fix scan out_axes #3540

merged 1 commit into from
Dec 8, 2023

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Dec 7, 2023

What does this PR do?

Fixes #3460. Fixes support for negative axis values.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (50cd169) 56.03% compared to head (9aa8ec6) 56.03%.

Files Patch % Lines
flax/core/axes_scan.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3540   +/-   ##
=======================================
  Coverage   56.03%   56.03%           
=======================================
  Files         100      100           
  Lines       11867    11867           
=======================================
  Hits         6650     6650           
  Misses       5217     5217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chiamp chiamp self-requested a review December 8, 2023 00:16
Copy link
Collaborator

@chiamp chiamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@copybara-service copybara-service bot merged commit 870847e into main Dec 8, 2023
21 checks passed
@copybara-service copybara-service bot deleted the linen-fix-scan-out-axes branch December 8, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using nn.scan with negative output_axes
3 participants