Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed quickstart #3451

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fixed quickstart #3451

merged 1 commit into from
Oct 31, 2023

Conversation

chiamp
Copy link
Collaborator

@chiamp chiamp commented Oct 30, 2023

A user got an error trying to run our Quickstart guide: TypeError: CNN.__call__() got an unexpected keyword argument 'compute_flops'.

The issue is because the colab installs Flax 0.7.4, whereas the PR that adds the compute_flops arg is in 0.7.5. This PR fixes this by installing a Flax version that's >= 0.7.5.

@chiamp chiamp self-assigned this Oct 30, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #3451 (a96626a) into main (c008753) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3451   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files          56       56           
  Lines        6802     6802           
=======================================
  Hits         5690     5690           
  Misses       1112     1112           

@chiamp chiamp requested a review from cgarciae October 30, 2023 20:29
@copybara-service copybara-service bot merged commit 6f69bb6 into google:main Oct 31, 2023
19 checks passed
@chiamp chiamp deleted the quickstart branch October 31, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants