Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused comment and fix typo. #8366

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Conversation

lamtrinhdev
Copy link
Contributor

Summary:

Update wording and remove unused comment.

  • Remove type parameter comment for readString because it does not existing.
  • serailizes => serializes
  • Aliginment => Alignment

Modifications:

  • swift/Sources/FlatBuffers/ByteBuffer.swift
  • swift/Sources/FlatBuffers/NativeObject.swift

Result:

Correct comment wording and remove unused comment.

Correct the word.
Type parameter does not existing, remove it.
Correct the word.
Copy link

google-cla bot commented Jul 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the swift label Jul 27, 2024
@lamtrinhdev lamtrinhdev changed the title Fix typo Fix typo and remove unused comment. Jul 27, 2024
@lamtrinhdev lamtrinhdev changed the title Fix typo and remove unused comment. Remove unused comment and fix typo. Jul 27, 2024
@dbaileychess dbaileychess enabled auto-merge (squash) August 20, 2024 03:07
@dbaileychess dbaileychess merged commit c065e97 into google:master Aug 20, 2024
48 checks passed
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
* Update NativeObject.swift

Correct the word.

* Update ByteBuffer.swift

Type parameter does not existing, remove it.

* Update ByteBuffer.swift

Correct the word.
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
* Update NativeObject.swift

Correct the word.

* Update ByteBuffer.swift

Type parameter does not existing, remove it.

* Update ByteBuffer.swift

Correct the word.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants