Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unit test for odd-sized small structs (for #8117) #8363

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

nolen777
Copy link
Contributor

@nolen777 nolen777 commented Jul 24, 2024

Adds a test with an odd-sized struct to alignment_test, to protect against recurrence of #8117

I verified that this new test passes. I also tried merging this change on top of 72aa85a, where the bug in 8117 first appeared; the test fails there with the expected bug (zero values present at the beginning of the vector).

Closes #8117

Copy link

google-cla bot commented Jul 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dbaileychess dbaileychess enabled auto-merge (squash) August 20, 2024 04:18
@dbaileychess dbaileychess merged commit 8db5932 into google:master Aug 20, 2024
47 of 49 checks passed
@mikemccarty-vertex
Copy link

Thanks again @nolen777 for your diligence.

jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
…#8363)

* add an odd sized test

* formatting

---------

Co-authored-by: Derek Bailey <[email protected]>
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
…#8363)

* add an odd sized test

* formatting

---------

Co-authored-by: Derek Bailey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants