Bugfix: grpc python code generation location and file suffix #8359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having filenames with . like `file.fb.grcp` is not great for Python. Since dots are used for namespaces. Replacing all of them with _ eg suffix `foo.bar.baz` will become `foo_bar_baz`. Restoring the previous default `_fb` suffix.
This fixes a regression introduced with: fb9afba And generates the grpc file in the namespace folder again.
fliiiix
force-pushed
the
bugfix/grpc-python-generation
branch
from
7519c47
to
95c0ab2
Compare
anton-bobukh
approved these changes
Jul 23, 2024
|
Can this be merged @dbaileychess or does it need something else? |
|
Any update if this can be merged? @dbaileychess @anton-bobukh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #8356.
This addresses the regression for the location where the
grpcfile is generated andchanges the default suffix back to
_fbagain instead of.fb.(See commit messages for more details).